Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8729)

Unified Diff: chrome/browser/ui/extensions/application_launch.h

Issue 114263005: Convert Extension* to extension id in AppLaunchParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: respond to comments Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/application_launch.h
diff --git a/chrome/browser/ui/extensions/application_launch.h b/chrome/browser/ui/extensions/application_launch.h
index 630f9e9d7a9e9cfc0c093e8cdaaad050c996bcbc..d42eaf9e2d0a255d0dcbc603c270194958fbd64c 100644
--- a/chrome/browser/ui/extensions/application_launch.h
+++ b/chrome/browser/ui/extensions/application_launch.h
@@ -5,6 +5,7 @@
#ifndef CHROME_BROWSER_UI_EXTENSIONS_APPLICATION_LAUNCH_H_
#define CHROME_BROWSER_UI_EXTENSIONS_APPLICATION_LAUNCH_H_
+#include "base/command_line.h"
#include "base/files/file_path.h"
#include "chrome/browser/ui/host_desktop.h"
#include "chrome/common/extensions/extension_constants.h"
@@ -49,7 +50,7 @@ struct AppLaunchParams {
Profile* profile;
// The extension to load.
- const extensions::Extension* extension;
+ std::string extension_id;
// The container type to launch the application in.
extensions::LaunchContainer container;
@@ -67,9 +68,9 @@ struct AppLaunchParams {
// position and dimensions.
gfx::Rect override_bounds;
- // If non-NULL, information from the command line may be passed on to the
+ // If non-empty, information from the command line may be passed on to the
// application.
- const CommandLine* command_line;
+ CommandLine command_line;
// If non-empty, the current directory from which any relative paths on the
// command line should be expanded from.

Powered by Google App Engine
This is Rietveld 408576698