apps/launcher.h - Issue 114263005: Convert Extension* to extension id in AppLaunchParams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: apps/launcher.h

Issue 114263005: Convert Extension* to extension id in AppLaunchParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix compile Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: apps/launcher.h

diff --git a/apps/launcher.h b/apps/launcher.h

index 8da998d4cfa378e27a4c1ae3a9c2bc6065cf1248..579da0fff1948cce69c9037a985b4158bcb8b464 100644

--- a/apps/launcher.h

+++ b/apps/launcher.h

@@ -23,11 +23,11 @@ namespace apps {

// Launches the platform app |extension|. Creates appropriate launch data for

-// NULL. A NULL |command_line| means there is no launch data. If non-empty,

+// NULL. An empty |command_line| means there is no launch data. If non-empty,

// |current_directory| is used to expand any relative paths on the command line.

void LaunchPlatformAppWithCommandLine(Profile* profile,

const extensions::Extension* extension,

- const CommandLine* command_line,

+ const CommandLine& command_line,

const base::FilePath& current_directory);

// Launches the platform app |extension| by issuing an onLaunched event

« no previous file with comments | « apps/app_load_service.cc ('k') | apps/launcher.cc » ('j') | no next file with comments »