chrome/browser/ui/startup/startup_browser_creator_impl.cc - Issue 114263005: Convert Extension* to extension id in AppLaunchParams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 114263005: Convert Extension* to extension id in AppLaunchParams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/extensions/application_launch.cc ('K') | « chrome/browser/ui/extensions/application_launch.cc ('k') | chrome/browser/ui/views/app_list/win/app_list_controller_delegate_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

index bf21accc40ff7b593139e2a1a2e800ba400af3fd..71aedb84d681fa18d1892e4a9800d026b177ecdc 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

@@ -371,7 +371,7 @@ bool StartupBrowserCreatorImpl::Launch(Profile* profile,

RecordCmdLineAppHistogram(extensions::Manifest::TYPE_PLATFORM_APP);

AppLaunchParams params(profile, extension,

extensions::LAUNCH_CONTAINER_NONE, NEW_WINDOW);

- params.command_line = &command_line_;

+ params.command_line = command_line_;

params.current_directory = cur_dir_;

OpenApplicationWithReenablePrompt(params);

return true;

@@ -523,7 +523,7 @@ bool StartupBrowserCreatorImpl::OpenApplicationWindow(

RecordCmdLineAppHistogram(extension->GetType());

AppLaunchParams params(profile, extension, launch_container, NEW_WINDOW);

- params.command_line = &command_line_;

+ params.command_line = command_line_;

params.current_directory = cur_dir_;

WebContents* tab_in_app_window = OpenApplication(params);