Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1142553002: remove #177 workaround (Closed)

Created:
5 years, 7 months ago by Jennifer Messerly
Modified:
5 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M lib/runtime/dart/_isolate_helper.js View 2 chunks +3 lines, -3 lines 0 comments Download
M test/generated_sdk/lib/_internal/compiler/js_lib/isolate_helper.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download
M tool/input_sdk/private/isolate_helper.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
5 years, 7 months ago (2015-05-14 21:42:36 UTC) #2
vsm
lgtm https://codereview.chromium.org/1142553002/diff/1/tool/input_sdk/private/isolate_helper.dart File tool/input_sdk/private/isolate_helper.dart (right): https://codereview.chromium.org/1142553002/diff/1/tool/input_sdk/private/isolate_helper.dart#newcode655 tool/input_sdk/private/isolate_helper.dart:655: // TODO(vsm): Revert to original pattern. Can you ...
5 years, 7 months ago (2015-05-14 22:04:28 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/1142553002/diff/1/tool/input_sdk/private/isolate_helper.dart File tool/input_sdk/private/isolate_helper.dart (right): https://codereview.chromium.org/1142553002/diff/1/tool/input_sdk/private/isolate_helper.dart#newcode655 tool/input_sdk/private/isolate_helper.dart:655: // TODO(vsm): Revert to original pattern. On 2015/05/14 22:04:28, ...
5 years, 7 months ago (2015-05-14 23:00:48 UTC) #4
Jennifer Messerly
5 years, 7 months ago (2015-05-14 23:02:44 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f3d492882b6a69cae3345b66e29f5228cd4ef63b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698