Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 1142533002: Make CFX_StringData be scoped by CFX_Bytestring and add methods. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make CFX_StringData be scoped by CFX_Bytestring and add methods. This is a precondition for someday combining Byte/Wide strings via templates. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/f33cdd54d5d5340d8a662048d9cf4abe7d5f0488

Patch Set 1 #

Total comments: 14

Patch Set 2 : Use class, kill tabs, whitespace. #

Patch Set 3 : Allocators ensure 1 beyond alloclen is always there. #

Patch Set 4 : Still more tabs. #

Total comments: 2

Patch Set 5 : indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -151 lines) Patch
M core/include/fxcrt/fx_string.h View 1 2 3 4 4 chunks +59 lines, -29 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring.cpp View 1 23 chunks +37 lines, -61 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring.cpp View 19 chunks +35 lines, -61 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Tom Sepez
Lei, for review. Mostly to make more intuitive to C++ devs. https://codereview.chromium.org/1142533002/diff/1/core/src/fxcrt/fx_basic_bstring.cpp File core/src/fxcrt/fx_basic_bstring.cpp (left): ...
5 years, 7 months ago (2015-05-14 18:06:46 UTC) #2
Lei Zhang
https://codereview.chromium.org/1142533002/diff/1/core/include/fxcrt/fx_string.h File core/include/fxcrt/fx_string.h (right): https://codereview.chromium.org/1142533002/diff/1/core/include/fxcrt/fx_string.h#newcode364 core/include/fxcrt/fx_string.h:364: void Retain() { ++m_nRefs; } Once a struct starts ...
5 years, 7 months ago (2015-05-14 19:28:39 UTC) #3
Tom Sepez
https://codereview.chromium.org/1142533002/diff/1/core/include/fxcrt/fx_string.h File core/include/fxcrt/fx_string.h (right): https://codereview.chromium.org/1142533002/diff/1/core/include/fxcrt/fx_string.h#newcode364 core/include/fxcrt/fx_string.h:364: void Retain() { ++m_nRefs; } On 2015/05/14 19:28:39, Lei ...
5 years, 7 months ago (2015-05-14 19:54:43 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/1142533002/diff/1/core/include/fxcrt/fx_string.h File core/include/fxcrt/fx_string.h (right): https://codereview.chromium.org/1142533002/diff/1/core/include/fxcrt/fx_string.h#newcode374 core/include/fxcrt/fx_string.h:374: : m_nRefs(1), m_nDataLength(dataLen), m_nAllocLength(allocLen) { On 2015/05/14 19:28:39, ...
5 years, 7 months ago (2015-05-14 20:50:14 UTC) #5
Tom Sepez
https://codereview.chromium.org/1142533002/diff/1/core/include/fxcrt/fx_string.h File core/include/fxcrt/fx_string.h (right): https://codereview.chromium.org/1142533002/diff/1/core/include/fxcrt/fx_string.h#newcode374 core/include/fxcrt/fx_string.h:374: : m_nRefs(1), m_nDataLength(dataLen), m_nAllocLength(allocLen) { On 2015/05/14 20:50:14, Lei ...
5 years, 7 months ago (2015-05-14 21:25:06 UTC) #6
Tom Sepez
5 years, 7 months ago (2015-05-14 21:26:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
f33cdd54d5d5340d8a662048d9cf4abe7d5f0488 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698