chromecast/browser/metrics/cast_metrics_service_client.h - Issue 1142513004: Chromecast: MessageLoopProxy cleanup --> SingleThreadTaskRunner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.h

Issue 1142513004: Chromecast: MessageLoopProxy cleanup --> SingleThreadTaskRunner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/browser/media/cma_message_loop.h ('K') | « chromecast/browser/media/cma_message_loop.cc ('k') | chromecast/browser/metrics/cast_metrics_service_client.cc » ('j') | chromecast/media/cdm/browser_cdm_cast.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/metrics/cast_metrics_service_client.h

diff --git a/chromecast/browser/metrics/cast_metrics_service_client.h b/chromecast/browser/metrics/cast_metrics_service_client.h

index abc2b57311c5141d4f62052f2cb06d67e60cede9..0dc17ff5a79c1fbf32b4900c0978d6aee82cd89f 100644

--- a/chromecast/browser/metrics/cast_metrics_service_client.h

+++ b/chromecast/browser/metrics/cast_metrics_service_client.h

@@ -15,7 +15,7 @@

class PrefService;

namespace base {

-class MessageLoopProxy;

+class SingleThreadTaskRunner;

class TaskRunner;

}

@@ -92,7 +92,7 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient {

#if defined(OS_LINUX)

ExternalMetrics* external_metrics_;

#endif // defined(OS_LINUX)

- const scoped_refptr<base::MessageLoopProxy> metrics_service_loop_;

+ const scoped_refptr<base::SingleThreadTaskRunner> metrics_service_loop_;

lcwu1 2015/05/19 01:45:37 Maybe change metrics_service_loop_ to metrics_serv

gunsch 2015/05/19 03:01:57 Done.

scoped_ptr< ::metrics::MetricsStateManager> metrics_state_manager_;

scoped_ptr< ::metrics::MetricsService> metrics_service_;

net::URLRequestContextGetter* const request_context_;