Chromecast: MessageLoopProxy cleanup --> SingleThreadTaskRunner.

Chromecast: MessageLoopProxy cleanup --> SingleThreadTaskRunner.

R=lcwu@chromium.org
BUG=391045
Committed: https://crrev.com/48c25c15f0c882cac698bf06759a270a3f2d3b5c
Cr-Commit-Position: refs/heads/master@{#330578}

[lcwu1, 2015-05-19 01:45:38]

https://codereview.chromium.org/1142513004/diff/1/chromecast/browser/media/cm...
File chromecast/browser/media/cma_message_loop.h (right):

https://codereview.chromium.org/1142513004/diff/1/chromecast/browser/media/cm...
chromecast/browser/media/cma_message_loop.h:13: class SingleThreadTaskRunner;
Redundant declaration.

https://codereview.chromium.org/1142513004/diff/1/chromecast/browser/metrics/...
File chromecast/browser/metrics/cast_metrics_service_client.h (right):

https://codereview.chromium.org/1142513004/diff/1/chromecast/browser/metrics/...
chromecast/browser/metrics/cast_metrics_service_client.h:95: const
scoped_refptr<base::SingleThreadTaskRunner> metrics_service_loop_;
Maybe change metrics_service_loop_ to metrics_service_runner_.

https://codereview.chromium.org/1142513004/diff/1/chromecast/media/cdm/browse...
File chromecast/media/cdm/browser_cdm_cast.h (right):

https://codereview.chromium.org/1142513004/diff/1/chromecast/media/cdm/browse...
chromecast/media/cdm/browser_cdm_cast.h:103: const
scoped_refptr<base::SingleThreadTaskRunner>& cdm_loop);
s/cdm_loop/cdm_runner

https://codereview.chromium.org/1142513004/diff/1/chromecast/media/cdm/browse...
chromecast/media/cdm/browser_cdm_cast.h:136:
scoped_refptr<base::SingleThreadTaskRunner> cdm_loop_;
Ditto.

https://codereview.chromium.org/1142513004/diff/1/chromecast/net/connectivity...
File chromecast/net/connectivity_checker.cc (right):

https://codereview.chromium.org/1142513004/diff/1/chromecast/net/connectivity...
chromecast/net/connectivity_checker.cc:38: const
scoped_refptr<base::SingleThreadTaskRunner>& loop_proxy)
Ditto.

https://codereview.chromium.org/1142513004/diff/1/chromecast/net/connectivity...
File chromecast/net/connectivity_checker.h (right):

https://codereview.chromium.org/1142513004/diff/1/chromecast/net/connectivity...
chromecast/net/connectivity_checker.h:48: const
scoped_refptr<base::SingleThreadTaskRunner>& loop_proxy);
s/loop_proxy/task_runner

https://codereview.chromium.org/1142513004/diff/1/chromecast/net/connectivity...
chromecast/net/connectivity_checker.h:90: const
scoped_refptr<base::SingleThreadTaskRunner> loop_proxy_;
Ditto.

[gunsch, 2015-05-19 03:01:58]

Thanks for review. I probably could have noted when mailing this out that the CL
was largely generated by:

1) Find/replace the following:
base::MessageLoopProxy::current --> base::ThreadTaskRunnerHandle::Get
base::MessageLoopProxy --> base::SingleThreadTaskRunner
base/message_loop/message_loop_proxy.h --> base/single_thread_task_runner.h
"class MessageLoopProxy" --> "class SingleThreadTaskRunner"
message_loop_proxy --> task_runner
CmaMessageLoop::GetMessageLoopProxy --> CmaMessageLoop::GetTaskRunner

2) Try to build, adding missing includes as necessary (for the few places
needing base/thread_task_runner_handle.h).

I'll probably do something similar with the internal repositories afterwards.

https://codereview.chromium.org/1142513004/diff/1/chromecast/browser/media/cm...
File chromecast/browser/media/cma_message_loop.h (right):

https://codereview.chromium.org/1142513004/diff/1/chromecast/browser/media/cm...
chromecast/browser/media/cma_message_loop.h:13: class SingleThreadTaskRunner;
On 2015/05/19 01:45:37, lcwu1 wrote:
> Redundant declaration.

Done.

https://codereview.chromium.org/1142513004/diff/1/chromecast/browser/metrics/...
File chromecast/browser/metrics/cast_metrics_service_client.h (right):

https://codereview.chromium.org/1142513004/diff/1/chromecast/browser/metrics/...
chromecast/browser/metrics/cast_metrics_service_client.h:95: const
scoped_refptr<base::SingleThreadTaskRunner> metrics_service_loop_;
On 2015/05/19 01:45:37, lcwu1 wrote:
> Maybe change metrics_service_loop_ to metrics_service_runner_.

Done.

https://codereview.chromium.org/1142513004/diff/1/chromecast/media/cdm/browse...
File chromecast/media/cdm/browser_cdm_cast.h (right):

https://codereview.chromium.org/1142513004/diff/1/chromecast/media/cdm/browse...
chromecast/media/cdm/browser_cdm_cast.h:103: const
scoped_refptr<base::SingleThreadTaskRunner>& cdm_loop);
On 2015/05/19 01:45:38, lcwu1 wrote:
> s/cdm_loop/cdm_runner

Done.

https://codereview.chromium.org/1142513004/diff/1/chromecast/media/cdm/browse...
chromecast/media/cdm/browser_cdm_cast.h:136:
scoped_refptr<base::SingleThreadTaskRunner> cdm_loop_;
On 2015/05/19 01:45:38, lcwu1 wrote:
> Ditto.

Done.

https://codereview.chromium.org/1142513004/diff/1/chromecast/net/connectivity...
File chromecast/net/connectivity_checker.cc (right):

https://codereview.chromium.org/1142513004/diff/1/chromecast/net/connectivity...
chromecast/net/connectivity_checker.cc:38: const
scoped_refptr<base::SingleThreadTaskRunner>& loop_proxy)
On 2015/05/19 01:45:38, lcwu1 wrote:
> Ditto.

Done.

https://codereview.chromium.org/1142513004/diff/1/chromecast/net/connectivity...
File chromecast/net/connectivity_checker.h (right):

https://codereview.chromium.org/1142513004/diff/1/chromecast/net/connectivity...
chromecast/net/connectivity_checker.h:48: const
scoped_refptr<base::SingleThreadTaskRunner>& loop_proxy);
On 2015/05/19 01:45:38, lcwu1 wrote:
> s/loop_proxy/task_runner

Done.

https://codereview.chromium.org/1142513004/diff/1/chromecast/net/connectivity...
chromecast/net/connectivity_checker.h:48: const
scoped_refptr<base::SingleThreadTaskRunner>& loop_proxy);
On 2015/05/19 01:45:38, lcwu1 wrote:
> s/loop_proxy/task_runner

Done.

https://codereview.chromium.org/1142513004/diff/1/chromecast/net/connectivity...
chromecast/net/connectivity_checker.h:90: const
scoped_refptr<base::SingleThreadTaskRunner> loop_proxy_;
On 2015/05/19 01:45:38, lcwu1 wrote:
> Ditto.

Done.

https://codereview.chromium.org/1142513004/diff/1/chromecast/net/connectivity...
chromecast/net/connectivity_checker.h:90: const
scoped_refptr<base::SingleThreadTaskRunner> loop_proxy_;
On 2015/05/19 01:45:38, lcwu1 wrote:
> Ditto.

Done.

[lcwu1, 2015-05-19 16:10:16]

lgtm

[gunsch, 2015-05-19 16:30:55]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2015-05-19 16:31:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1142513004/20001

[commit-bot: I haz the power, 2015-05-19 16:54:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-19 16:54:28]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[gunsch, 2015-05-19 18:32:55]

The CQ bit was checked by gunsch@chromium.org

[gunsch, 2015-05-19 18:32:56]

The patchset sent to the CQ was uploaded after l-g-t-m from lcwu@chromium.org
Link to the patchset: https://codereview.chromium.org/1142513004/#ps40001
(title: "fix compile failure introduced in review comments")

[commit-bot: I haz the power, 2015-05-19 18:34:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1142513004/40001

[commit-bot: I haz the power, 2015-05-19 18:41:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-19 18:41:34]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[gunsch, 2015-05-19 18:44:01]

The CQ bit was checked by gunsch@chromium.org

[gunsch, 2015-05-19 18:44:01]

The patchset sent to the CQ was uploaded after l-g-t-m from lcwu@chromium.org
Link to the patchset: https://codereview.chromium.org/1142513004/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2015-05-19 18:44:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1142513004/60001

[commit-bot: I haz the power, 2015-05-19 18:57:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-19 18:58:12]

Patchset 4 (id:??) landed as
https://crrev.com/48c25c15f0c882cac698bf06759a270a3f2d3b5c
Cr-Commit-Position: refs/heads/master@{#330578}