Optionally add project through buildbot onto the waterfall.

Optionally add project through buildbot onto the waterfall.

This makes the project available to the change template in order to
separate different change sources on the waterfall.

BUG=162403
TEST=LOCAL (main & webkit use)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169735

[Peter Mayo, 2012-11-23 03:09:42]

Not sure if this is upstreamable.

[Peter Mayo, 2012-11-23 03:19:31]

and scripts/master/chromium_status_bb8.py doesn't seem to need to be changed
before any template uses the new parameter.  That may be fragile but I thought
it better to separate the 3rd party part of the code.

[Peter Mayo, 2012-11-23 16:30:00]

I'd like to make the change during the idle time for MTV.

[M-A Ruel, 2012-11-23 16:32:55]

On 2012/11/23 16:30:00, Peter Mayo wrote:
> I'd like to make the change during the idle time for MTV.

Can you upload again? The patchset is broken.

[M-A Ruel, 2012-11-23 16:44:43]

On 2012/11/23 03:09:42, Peter Mayo wrote:
> Not sure if this is upstreamable.

Can you ask upstream first and see if it's mergeable in branches 0.8 and 0.9?

[Peter Mayo, 2012-11-23 17:10:15]

https://codereview.chromium.org/11425002/diff/6001/third_party/buildbot_8_4p1...
File third_party/buildbot_8_4p1/README.chromium (right):

https://codereview.chromium.org/11425002/diff/6001/third_party/buildbot_8_4p1...
third_party/buildbot_8_4p1/README.chromium:594: Add revision to changes in the
waterfall.
Re: upstreaming.

Given that this is a local change, extending it to have both revision and
project seems unlikely.

[Peter Mayo, 2012-11-23 18:21:30]

Upstream request generated:

https://github.com/buildbot/buildbot/pull/582

[Peter Mayo, 2012-11-23 18:44:51]

On 2012/11/23 18:21:30, Peter Mayo wrote:
> Upstream request generated:
> 
> https://github.com/buildbot/buildbot/pull/582

Oh - and the patches applied cleanly at ToT.
Regardless we are going to want to keep the behavioral changes local, so I think
this makes sense to go in 8_4p1 for us, even if we won't have to move all of it
over to a later version when we next upgrade.

Removed the patch that was partially uploaded at the start of yesterday's
outage.

[Peter Mayo, 2012-11-27 14:45:44]

On 2012/11/23 18:44:51, Peter Mayo wrote:
> On 2012/11/23 18:21:30, Peter Mayo wrote:
> > Upstream request generated:
> > 
> > https://github.com/buildbot/buildbot/pull/582
> 
> Oh - and the patches applied cleanly at ToT.
> Regardless we are going to want to keep the behavioral changes local, so I
think
> this makes sense to go in 8_4p1 for us, even if we won't have to move all of
it
> over to a later version when we next upgrade.
> 
> Removed the patch that was partially uploaded at the start of yesterday's
> outage.

The patch (and the business part of the predecessor) has been merged to ToT
upstream.

[M-A Ruel, 2012-11-27 15:03:05]

https://codereview.chromium.org/11425002/diff/6001/third_party/buildbot_8_4p1...
File third_party/buildbot_8_4p1/README.chromium (right):

https://codereview.chromium.org/11425002/diff/6001/third_party/buildbot_8_4p1...
third_party/buildbot_8_4p1/README.chromium:2730: Be able to differentiate change
sources by project.
Please add the commit hash upstream

[Peter Mayo, 2012-11-27 19:07:02]

On 2012/11/27 15:03:05, Marc-Antoine Ruel wrote:
> Please add the commit hash upstream

Done

[M-A Ruel, 2012-11-27 19:14:30]

lgtm with nit for stricter formatting in the README.

https://codereview.chromium.org/11425002/diff/2003/third_party/buildbot_8_4p1...
File third_party/buildbot_8_4p1/README.chromium (right):

https://codereview.chromium.org/11425002/diff/2003/third_party/buildbot_8_4p1...
third_party/buildbot_8_4p1/README.chromium:2700: Add upstream patch
68a1a5da05e9761f1d283f23905cd9104e05e979 to enable
I prefer the format diff of lines 597-605 but with the diff applied here.

[Peter Mayo, 2012-11-27 20:03:39]

On 2012/11/27 19:14:30, Marc-Antoine Ruel wrote:
> lgtm with nit for stricter formatting in the README.
> 
>
https://codereview.chromium.org/11425002/diff/2003/third_party/buildbot_8_4p1...
> File third_party/buildbot_8_4p1/README.chromium (right):
> 
>
https://codereview.chromium.org/11425002/diff/2003/third_party/buildbot_8_4p1...
> third_party/buildbot_8_4p1/README.chromium:2700: Add upstream patch
> 68a1a5da05e9761f1d283f23905cd9104e05e979 to enable
> I prefer the format diff of lines 597-605 but with the diff applied here.

I think I have fixed it ... looking at the git log I was wrong about the patches
being merged together, they were merged to trunk.

[M-A Ruel, 2012-11-27 20:07:40]

thanks, lgtm

[commit-bot: I haz the power, 2012-11-27 20:42:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/petermayo@chromium.org/11425002/14006

[commit-bot: I haz the power, 2012-11-27 20:43:55]

Change committed as 169735