Issue 1142463002: Plumb dependencies on content from test plugin through the delegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1142463002: Plumb dependencies on content from test plugin through the delegate (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 7 months ago

Reviewers:
Mike West

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Plumb dependencies on content from test plugin through the delegate R=mkwst@chromium.org BUG=478250 Committed: https://crrev.com/bc9894398ed87cebf054991ec48c32a303b11192 Cr-Commit-Position: refs/heads/master@{#329802}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -4 lines)			Patch
M	content/shell/renderer/layout_test/blink_test_runner.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/shell/renderer/layout_test/blink_test_runner.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	content/shell/renderer/test_runner/test_plugin.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/shell/renderer/test_runner/test_plugin.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	content/shell/renderer/test_runner/web_test_delegate.h	View	3 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142463002/1

5 years, 7 months ago (2015-05-14 04:43:44 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-14 04:48:30 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bc9894398ed87cebf054991ec48c32a303b11192
Cr-Commit-Position: refs/heads/master@{#329802}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages