Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sync/engine/get_commit_ids.cc

Issue 1142423006: Sync: fixed Implicit Permanent Folders issues found when testing with alpha server (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Bumped protocol version Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/protocol/sync.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/get_commit_ids.cc
diff --git a/sync/engine/get_commit_ids.cc b/sync/engine/get_commit_ids.cc
index f87524d66c0b44f0f975054f189928b1426bf414..c9b5a5b27045dde832666f72cb63bec81a6bc837 100644
--- a/sync/engine/get_commit_ids.cc
+++ b/sync/engine/get_commit_ids.cc
@@ -453,7 +453,8 @@ bool Traversal::HaveItem(int64 handle) const {
}
bool Traversal::SupportsHierarchy(const syncable::Entry& item) const {
- return !item.GetParentId().IsNull();
+ // Types with explicit server supported hierarchy only.
+ return IsTypeWithServerGeneratedRoot(item.GetModelType());
}
void Traversal::AppendManyToTraversal(
« no previous file with comments | « no previous file | sync/protocol/sync.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698