Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1142423004: Make GN header checker more lenient about toolchains. (Closed)

Created:
5 years, 7 months ago by brettw
Modified:
5 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make GN header checker more lenient about toolchains. The header checker will now automatically accept any headers not known in the current toolchain. The previous code would do this but required it to not be present in any toolchain in the entire build. See the long comment added in header_checker.cc for details. Adds a dependency fix for the Android build in base. BUG= Committed: https://crrev.com/a9adafeae2a97bc5a9676b4072ddf8491c212c4d Cr-Commit-Position: refs/heads/master@{#330839}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -13 lines) Patch
M base/memory/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/gn/header_checker.cc View 2 chunks +27 lines, -12 lines 0 comments Download
M tools/gn/header_checker_unittest.cc View 1 2 chunks +28 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
brettw
5 years, 7 months ago (2015-05-20 22:17:03 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142423004/20001
5 years, 7 months ago (2015-05-20 22:18:08 UTC) #4
scottmg
lgtm
5 years, 7 months ago (2015-05-20 22:26:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142423004/20001
5 years, 7 months ago (2015-05-20 22:29:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-20 23:32:46 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 23:34:31 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a9adafeae2a97bc5a9676b4072ddf8491c212c4d
Cr-Commit-Position: refs/heads/master@{#330839}

Powered by Google App Engine
This is Rietveld 408576698