[Android] Fix android_profiling_helper pulling lib from device.

[Android] Fix android_profiling_helper pulling lib from device.

Telemetry's android_profiling_helper currently fails when trying to pull
a library from the device if the library doesn't already exist on the host
(read: most if not all of the time). This patch fixes that.

BUG=489969
Committed: https://crrev.com/5fd85a26e10f4356f2efe996a97e5b2e459414b7
Cr-Commit-Position: refs/heads/master@{#330744}

[jbudorick, 2015-05-20 04:54:49]

jbudorick@chromium.org changed reviewers:
+ skyostil@chromium.org

[Sami, 2015-05-20 11:00:11]

On 2015/05/20 04:54:50, jbudorick wrote:

Thanks for the fix, lgtm.

FWIW, you may have noticed but there's a test for this which is disabled:
https://code.google.com/p/chromium/issues/detail?id=437081. I tried to enable it
once but it failed on the bots for some unknown reason :\

[jbudorick, 2015-05-20 14:52:08]

On 2015/05/20 11:00:11, Sami wrote:
> On 2015/05/20 04:54:50, jbudorick wrote:
> 
> Thanks for the fix, lgtm.
> 
> FWIW, you may have noticed but there's a test for this which is disabled:
> https://code.google.com/p/chromium/issues/detail?id=437081. I tried to enable
it
> once but it failed on the bots for some unknown reason :\

Tried to fix it in the latest patchset, verified on K+L. The other test fails on
K (but not L) because the version of the SDK in our checkout doesn't have the
GCC 4.7 toolchain.

ptal

[Sami, 2015-05-20 14:57:22]

Thanks very much for unbreaking the test! One tiny question below.

https://codereview.chromium.org/1142413002/diff/20001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py
(right):

https://codereview.chromium.org/1142413002/diff/20001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py:212:
pull = (not host_md5sums or not device_md5sums
Aren't we guaranteed to have host_md5sums at this point? (barring any unrelated
failures)

[jbudorick, 2015-05-20 15:08:13]

https://codereview.chromium.org/1142413002/diff/20001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py
(right):

https://codereview.chromium.org/1142413002/diff/20001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py:212:
pull = (not host_md5sums or not device_md5sums
On 2015/05/20 14:57:21, Sami wrote:
> Aren't we guaranteed to have host_md5sums at this point? (barring any
unrelated
> failures)

barring unrelated failures, yes

[Sami, 2015-05-20 15:14:25]

lgtm.

https://codereview.chromium.org/1142413002/diff/20001/tools/telemetry/telemet...
File
tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py
(right):

https://codereview.chromium.org/1142413002/diff/20001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py:212:
pull = (not host_md5sums or not device_md5sums
On 2015/05/20 15:08:13, jbudorick wrote:
> On 2015/05/20 14:57:21, Sami wrote:
> > Aren't we guaranteed to have host_md5sums at this point? (barring any
> unrelated
> > failures)
> 
> barring unrelated failures, yes

ok, let's leave the check in then :)

[jbudorick, 2015-05-20 15:59:09]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2015-05-20 15:59:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1142413002/20001

[commit-bot: I haz the power, 2015-05-20 16:09:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-20 16:10:00]

Patchset 2 (id:??) landed as
https://crrev.com/5fd85a26e10f4356f2efe996a97e5b2e459414b7
Cr-Commit-Position: refs/heads/master@{#330744}