Refactor StatementRewriter: Extract method for rewriting a list left-to-right.

pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of tree_ir.optimization;
 
 /**
  * Performs the following transformations on the tree:
  * - Assignment inlining
  * - Assignment expression propagation
@@ skipping 325 matching lines @@
       node.next = visitStatement(node.next);
     } else {
       inEmptyEnvironment(() {
         node.next = visitStatement(node.next);
       });
     }
     node.value = visitExpression(node.value);
     return node;
   }
 
+  /// Process nodes right-to-left, the opposite of evaluation order in the case
+  /// of argument lists..
+  void _rewriteList(List<Node> nodes) {
+    for (int i = nodes.length - 1; i >= 0; --i) {
+      nodes[i] = visitExpression(nodes[i]);
+    }
+  }
+
   Expression visitInvokeStatic(InvokeStatic node) {
-    // Process arguments right-to-left, the opposite of evaluation order.
-    for (int i = node.arguments.length - 1; i >= 0; --i) {
-      node.arguments[i] = visitExpression(node.arguments[i]);
-    }
+    _rewriteList(node.arguments);
     return node;
   }
 
   Expression visitInvokeMethod(InvokeMethod node) {
-    for (int i = node.arguments.length - 1; i >= 0; --i) {
-      node.arguments[i] = visitExpression(node.arguments[i]);
-    }
+    _rewriteList(node.arguments);
     node.receiver = visitExpression(node.receiver);
     return node;
   }
 
   Expression visitInvokeMethodDirectly(InvokeMethodDirectly node) {
-    for (int i = node.arguments.length - 1; i >= 0; --i) {
-      node.arguments[i] = visitExpression(node.arguments[i]);
-    }
+    _rewriteList(node.arguments);
     node.receiver = visitExpression(node.receiver);
     return node;
   }
 
   Expression visitInvokeConstructor(InvokeConstructor node) {
-    for (int i = node.arguments.length - 1; i >= 0; --i) {
-      node.arguments[i] = visitExpression(node.arguments[i]);
-    }
+    _rewriteList(node.arguments);
     return node;
   }
 
   Expression visitConcatenateStrings(ConcatenateStrings node) {
-    for (int i = node.arguments.length - 1; i >= 0; --i) {
-      node.arguments[i] = visitExpression(node.arguments[i]);
-    }
+    _rewriteList(node.arguments);
     return node;
   }
 
   Expression visitConditional(Conditional node) {
     // Conditional expressions do not exist in the input, but they are
     // introduced by if-to-conditional conversion.
     // Their subexpressions have already been processed; do not reprocess them.
     //
     // Note that this can only happen for conditional expressions. It is an
     // error for any other type of expression to be visited twice or to be
@@ skipping 163 matching lines @@
 
   Expression visitThis(This node) {
     return node;
   }
 
   Expression visitReifyTypeVar(ReifyTypeVar node) {
     return node;
   }
 
   Expression visitLiteralList(LiteralList node) {
-    // Process values right-to-left, the opposite of evaluation order.
-    for (int i = node.values.length - 1; i >= 0; --i) {
-      node.values[i] = visitExpression(node.values[i]);
-    }
+    _rewriteList(node.values);
     return node;
   }
 
   Expression visitLiteralMap(LiteralMap node) {
     // Process arguments right-to-left, the opposite of evaluation order.
     for (LiteralMapEntry entry in node.entries.reversed) {
       entry.value = visitExpression(entry.value);
       entry.key = visitExpression(entry.key);
     }
     return node;
@@ skipping 22 matching lines @@
   Expression visitSetStatic(SetStatic node) {
     node.value = visitExpression(node.value);
     return node;
   }
 
   Expression visitCreateBox(CreateBox node) {
     return node;
   }
 
   Expression visitCreateInstance(CreateInstance node) {
-    for (int i = node.arguments.length - 1; i >= 0; --i) {
-      node.arguments[i] = visitExpression(node.arguments[i]);
-    }
+    _rewriteList(node.arguments);
     return node;
   }
 
   Expression visitReifyRuntimeType(ReifyRuntimeType node) {
     node.value = visitExpression(node.value);
     return node;
   }
 
   Expression visitReadTypeVariable(ReadTypeVariable node) {
     node.target = visitExpression(node.target);
     return node;
   }
 
   Expression visitTypeExpression(TypeExpression node) {
-    for (int i = node.arguments.length - 1; i >= 0; --i) {
-      node.arguments[i] = visitExpression(node.arguments[i]);
-    }
+    _rewriteList(node.arguments);
     return node;
   }
 
   Expression visitCreateInvocationMirror(CreateInvocationMirror node) {
-    for (int i = node.arguments.length - 1; i >= 0; --i) {
-      node.arguments[i] = visitExpression(node.arguments[i]);
-    }
+    _rewriteList(node.arguments);
     return node;
   }
 
   /// If [s] and [t] are similar statements we extract their subexpressions
   /// and returns a new statement of the same type using expressions combined
   /// with the [combine] callback. For example:
   ///
   ///   combineStatements(Return E1, Return E2) = Return combine(E1, E2)
   ///
   /// If [combine] returns E1 then the unified statement is equivalent to [s],
@@ skipping 287 matching lines @@
 }
 
 /// Result of combining two expressions that do not affect reference counting.
 class GenericCombinedExpressions implements CombinedExpressions {
   Expression combined;
 
   GenericCombinedExpressions(this.combined);
 
   void uncombine() {}
 }