Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1142353003: Rename load_library_from_zip_file -> load_library_from_zip (Closed)

Created:
5 years, 7 months ago by agrieve
Modified:
5 years, 7 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename load_library_from_zip_file -> load_library_from_zip Having load_library_from_zip_file end with "_file" causes a GYP exception when the value is overriden. BUG=488135 Committed: https://crrev.com/1b841e014d528f802b93c4284b90db39b90b63fc Cr-Commit-Position: refs/heads/master@{#330888}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : Fix up one missed rebase line :S #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M build/android/finalize_apk_action.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/gyp/finalize_apk.py View 3 chunks +3 lines, -3 lines 0 comments Download
M build/android/rezip/RezipApk.java View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/internal_rules.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M build/java_apk.gypi View 1 2 5 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
agrieve
5 years, 7 months ago (2015-05-20 14:40:01 UTC) #2
cjhopman
lgtm
5 years, 7 months ago (2015-05-20 21:03:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142353003/20001
5 years, 7 months ago (2015-05-20 23:56:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/78833) android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-05-21 00:07:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142353003/40001
5 years, 7 months ago (2015-05-21 00:41:55 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-21 04:38:41 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 04:41:18 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1b841e014d528f802b93c4284b90db39b90b63fc
Cr-Commit-Position: refs/heads/master@{#330888}

Powered by Google App Engine
This is Rietveld 408576698