Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1142343009: grokdump.py - some support for on-stack HeapStats (Closed)

Created:
5 years, 6 months ago by Erik Corry Chromium.org
Modified:
5 years, 6 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

grokdump.py - some support for on-stack HeapStats R=ulan@chromium.org BUG= Committed: https://crrev.com/2cb39206880dfface9315c3d1a2bb3a86316d06a Cr-Commit-Position: refs/heads/master@{#28694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M tools/grokdump.py View 1 chunk +22 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Erik Corry Chromium.org
5 years, 6 months ago (2015-05-28 16:38:24 UTC) #1
ulan
lgtm
5 years, 6 months ago (2015-05-29 07:39:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142343009/1
5 years, 6 months ago (2015-05-29 08:29:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-29 09:05:03 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 09:05:15 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2cb39206880dfface9315c3d1a2bb3a86316d06a
Cr-Commit-Position: refs/heads/master@{#28694}

Powered by Google App Engine
This is Rietveld 408576698