Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5059)

Unified Diff: cc/resources/resource_provider_unittest.cc

Issue 1142343008: cc: Rework overlays to not use the ResourceProvider and pass texture size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix more tests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/resource_provider_unittest.cc
diff --git a/cc/resources/resource_provider_unittest.cc b/cc/resources/resource_provider_unittest.cc
index 7ad0e8678f58ecd019bb9dfc211d663fcfbe1ce4..2982a3d462d440faa169ec75c1260c31e3d8cb72 100644
--- a/cc/resources/resource_provider_unittest.cc
+++ b/cc/resources/resource_provider_unittest.cc
@@ -1045,55 +1045,6 @@ TEST_P(ResourceProviderTest, ReadLockCountStopsReturnToChildOrDelete) {
resource_provider_->DestroyChild(child_id);
}
-TEST_P(ResourceProviderTest, AllowOverlayTransfersToParent) {
- // Overlays only supported on the GL path.
- if (GetParam() != ResourceProvider::RESOURCE_TYPE_GL_TEXTURE)
- return;
-
- uint32 sync_point = 0;
- TextureMailbox mailbox(gpu::Mailbox::Generate(), GL_TEXTURE_2D, sync_point);
- mailbox.set_allow_overlay(true);
- scoped_ptr<SingleReleaseCallbackImpl> release_callback =
- SingleReleaseCallbackImpl::Create(base::Bind(&EmptyReleaseCallback));
- ResourceId id1 = child_resource_provider_->CreateResourceFromTextureMailbox(
- mailbox, release_callback.Pass());
-
- TextureMailbox mailbox2(gpu::Mailbox::Generate(), GL_TEXTURE_2D, sync_point);
- mailbox2.set_allow_overlay(false);
- scoped_ptr<SingleReleaseCallbackImpl> release_callback2 =
- SingleReleaseCallbackImpl::Create(base::Bind(&EmptyReleaseCallback));
- ResourceId id2 = child_resource_provider_->CreateResourceFromTextureMailbox(
- mailbox2, release_callback2.Pass());
-
- ReturnedResourceArray returned_to_child;
- int child_id =
- resource_provider_->CreateChild(GetReturnCallback(&returned_to_child));
-
- // Transfer some resources to the parent.
- ResourceProvider::ResourceIdArray resource_ids_to_transfer;
- resource_ids_to_transfer.push_back(id1);
- resource_ids_to_transfer.push_back(id2);
- TransferableResourceArray list;
- child_resource_provider_->PrepareSendToParent(resource_ids_to_transfer,
- &list);
- ASSERT_EQ(2u, list.size());
- resource_provider_->ReceiveFromChild(child_id, list);
- EXPECT_TRUE(resource_provider_->AllowOverlay(list[0].id));
- EXPECT_FALSE(resource_provider_->AllowOverlay(list[1].id));
-
- resource_provider_->DeclareUsedResourcesFromChild(
- child_id, ResourceProvider::ResourceIdSet());
-
- EXPECT_EQ(2u, returned_to_child.size());
- child_resource_provider_->ReceiveReturnsFromParent(returned_to_child);
-
- child_resource_provider_->DeleteResource(id1);
- child_resource_provider_->DeleteResource(id2);
- EXPECT_EQ(0u, child_resource_provider_->num_resources());
-
- resource_provider_->DestroyChild(child_id);
-}
-
TEST_P(ResourceProviderTest, TransferSoftwareResources) {
if (GetParam() != ResourceProvider::RESOURCE_TYPE_BITMAP)
return;

Powered by Google App Engine
This is Rietveld 408576698