Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3636)

Unified Diff: cc/resources/resource_provider.cc

Issue 1142343008: cc: Rework overlays to not use the ResourceProvider and pass texture size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix more tests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/resource_provider.cc
diff --git a/cc/resources/resource_provider.cc b/cc/resources/resource_provider.cc
index 07ce62c88352cfad3533970f4261ba455bd9d215..26f587d7887b6cf4bc4e0d69fcfa9cd960759ed5 100644
--- a/cc/resources/resource_provider.cc
+++ b/cc/resources/resource_provider.cc
@@ -277,7 +277,6 @@ ResourceProvider::Resource::Resource(GLuint texture_id,
allocated(false),
read_lock_fences_enabled(false),
has_shared_bitmap_id(false),
- allow_overlay(false),
read_lock_fence(NULL),
size(size),
origin(origin),
@@ -321,7 +320,6 @@ ResourceProvider::Resource::Resource(uint8_t* pixels,
allocated(false),
read_lock_fences_enabled(false),
has_shared_bitmap_id(!!bitmap),
- allow_overlay(false),
read_lock_fence(NULL),
size(size),
origin(origin),
@@ -366,7 +364,6 @@ ResourceProvider::Resource::Resource(const SharedBitmapId& bitmap_id,
allocated(false),
read_lock_fences_enabled(false),
has_shared_bitmap_id(true),
- allow_overlay(false),
read_lock_fence(NULL),
size(size),
origin(origin),
@@ -450,11 +447,6 @@ bool ResourceProvider::IsLost(ResourceId id) {
return resource->lost;
}
-bool ResourceProvider::AllowOverlay(ResourceId id) {
- Resource* resource = GetResource(id);
- return resource->allow_overlay;
-}
-
ResourceId ResourceProvider::CreateResource(const gfx::Size& size,
GLint wrap_mode,
TextureHint hint,
@@ -574,7 +566,7 @@ ResourceId ResourceProvider::CreateResourceFromTextureMailbox(
uint8_t* pixels = shared_bitmap->pixels();
DCHECK(pixels);
resource = InsertResource(
- id, Resource(pixels, shared_bitmap, mailbox.shared_memory_size(),
+ id, Resource(pixels, shared_bitmap, mailbox.size_in_pixels(),
Resource::EXTERNAL, GL_LINEAR, GL_CLAMP_TO_EDGE));
}
resource->allocated = true;
@@ -582,7 +574,6 @@ ResourceId ResourceProvider::CreateResourceFromTextureMailbox(
resource->release_callback_impl =
base::Bind(&SingleReleaseCallbackImpl::Run,
base::Owned(release_callback_impl.release()));
- resource->allow_overlay = mailbox.allow_overlay();
return id;
}
@@ -1387,7 +1378,6 @@ void ResourceProvider::ReceiveFromChild(
// Don't allocate a texture for a child.
resource->allocated = true;
resource->imported_count = 1;
- resource->allow_overlay = it->allow_overlay;
child_info.parent_to_child_map[local_id] = it->id;
child_info.child_to_parent_map[it->id] = local_id;
}
@@ -1491,7 +1481,6 @@ void ResourceProvider::TransferResource(GLES2Interface* gl,
resource->filter = source->filter;
resource->size = source->size;
resource->is_repeated = (source->wrap_mode == GL_REPEAT);
- resource->allow_overlay = source->allow_overlay;
if (source->type == RESOURCE_TYPE_BITMAP) {
resource->mailbox_holder.mailbox = source->shared_bitmap_id;

Powered by Google App Engine
This is Rietveld 408576698