cc/layers/video_layer_impl.h - Issue 1142343008: cc: Rework overlays to not use the ResourceProvider and pass texture size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/video_layer_impl.h

Issue 1142343008: cc: Rework overlays to not use the ResourceProvider and pass texture size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/video_layer_impl.h

diff --git a/cc/layers/video_layer_impl.h b/cc/layers/video_layer_impl.h

index 5b3d9550e27df49c2209ed634bbe07eb3b89da3e..5570fb8d82adf6c0d38fefcd21d277c933550d69 100644

--- a/cc/layers/video_layer_impl.h

+++ b/cc/layers/video_layer_impl.h

@@ -62,7 +62,13 @@ class CC_EXPORT VideoLayerImpl : public LayerImpl {

scoped_ptr<VideoResourceUpdater> updater_;

VideoFrameExternalResources::ResourceType frame_resource_type_;

- std::vector<ResourceId> frame_resources_;

+ struct FrameResource {

+ FrameResource(ResourceId id, gfx::Size size, bool allow_overlay);

danakj 2015/05/29 20:04:14 you could inline this constructor, the type is sim

achaulk 2015/06/01 15:43:10 Done.

+ ResourceId id;

+ gfx::Size size;

danakj 2015/05/29 20:04:14 size_in_pixels?

achaulk 2015/06/01 15:43:10 Done.

+ bool allow_overlay;

+ };

+ std::vector<FrameResource> frame_resources_;

// TODO(danakj): Remove these, hide software path inside ResourceProvider and

// ExternalResource (aka TextureMailbox) classes.

« cc/layers/texture_layer_impl.cc ('K') | « cc/layers/texture_layer_impl.cc ('k') | cc/layers/video_layer_impl.cc » ('j') | cc/output/overlay_candidate.h » ('J')