Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: test/analyzer/gyptest-analyzer.py

Issue 1142323006: Makes analyzer always output static_libraries that have changed (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: is_or_has_linked_ancestor Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/analyzer/gyptest-analyzer.py
diff --git a/test/analyzer/gyptest-analyzer.py b/test/analyzer/gyptest-analyzer.py
index 537d1c80b6bfefd37cd4248d15987a34357735c9..ed9a7deeb984435ac585a06e8d0f94b444acf710 100644
--- a/test/analyzer/gyptest-analyzer.py
+++ b/test/analyzer/gyptest-analyzer.py
@@ -15,7 +15,7 @@ not_found = 'No dependencies'
def _CreateConfigFile(files, targets):
- """Creates the analyzer conflig file, which is used as the input to analyzer.
+ """Creates the analyzer config file, which is used as the input to analyzer.
See description of analyzer.py for description of the arguments."""
f = open('test_file', 'w')
to_write = {'files': files, 'targets': targets }
@@ -144,6 +144,15 @@ def EnsureInvalidTargets(expected_invalid_targets):
'\nexpected :', expected_invalid_targets
test.fail_test()
+
+# Two targets, A and B (both static_libraries) and A depends upon B. If a file
+# in B changes, then both A and B are output. It is not strictly necessary that
+# A is compiled in this case, only B.
+_CreateConfigFile(['b.c'], [])
+test.run_gyp('static_library_test.gyp', *CommonArgs())
+EnsureContains(matched=True, build_targets={'a' ,'b'})
+#test.pass_test()
Nico 2015/06/08 17:53:31 is this intentionally commented out? probably not?
sky 2015/06/08 18:01:17 Ya, sorry, I removed this line. test.pass_test()
+
# Verifies config_path must be specified.
test.run_gyp('test.gyp')
EnsureStdoutContains('Must specify files to analyze via config_path')
@@ -351,6 +360,6 @@ EnsureContains(matched=True, build_targets={'a', 'b', 'c', 'd'})
_CreateConfigFile(['i.c'], [])
run_analyzer4()
-EnsureContains(matched=True, build_targets={'h'})
+EnsureContains(matched=True, build_targets={'h', 'i'})
test.pass_test()

Powered by Google App Engine
This is Rietveld 408576698