Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 1142323006: Makes analyzer always output static_libraries that have changed (Closed)

Created:
5 years, 6 months ago by sky
Modified:
5 years, 6 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Makes analyzer always output static_libraries that have changed This is to deal with static_libraries not being compile dependencies. In particular if we only output the topmost ancestor that depends upon the static library then the static library may not get built if the ancestor is a static_library itself. BUG=gyp:493 TEST=covered by test R=thakis@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/fdc7b812f99e48c00e9a487bd56751bbeae07043

Patch Set 1 #

Patch Set 2 : comment and no-find-copies #

Total comments: 2

Patch Set 3 : is_or_has_linked_ancestor #

Total comments: 4

Patch Set 4 : comments #

Patch Set 5 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -5 lines) Patch
M pylib/gyp/generator/analyzer.py View 1 2 3 4 chunks +19 lines, -3 lines 0 comments Download
M test/analyzer/gyptest-analyzer.py View 1 2 3 3 chunks +10 lines, -2 lines 0 comments Download
A test/analyzer/static_library_test.gyp View 1 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
sky
5 years, 6 months ago (2015-06-08 17:31:44 UTC) #2
Nico
https://codereview.chromium.org/1142323006/diff/20001/pylib/gyp/generator/analyzer.py File pylib/gyp/generator/analyzer.py (right): https://codereview.chromium.org/1142323006/diff/20001/pylib/gyp/generator/analyzer.py#newcode436 pylib/gyp/generator/analyzer.py:436: not target.is_or_has_executable_ancestor)): you care about "is_or_has_linked_ancestor", right? (in particular, ...
5 years, 6 months ago (2015-06-08 17:37:56 UTC) #3
sky
https://codereview.chromium.org/1142323006/diff/20001/pylib/gyp/generator/analyzer.py File pylib/gyp/generator/analyzer.py (right): https://codereview.chromium.org/1142323006/diff/20001/pylib/gyp/generator/analyzer.py#newcode436 pylib/gyp/generator/analyzer.py:436: not target.is_or_has_executable_ancestor)): On 2015/06/08 17:37:56, Nico wrote: > you ...
5 years, 6 months ago (2015-06-08 17:46:26 UTC) #4
Nico
lgtm https://codereview.chromium.org/1142323006/diff/40001/pylib/gyp/generator/analyzer.py File pylib/gyp/generator/analyzer.py (right): https://codereview.chromium.org/1142323006/diff/40001/pylib/gyp/generator/analyzer.py#newcode430 pylib/gyp/generator/analyzer.py:430: # executables. This is necessary as the other ...
5 years, 6 months ago (2015-06-08 17:53:31 UTC) #5
sky
https://codereview.chromium.org/1142323006/diff/40001/pylib/gyp/generator/analyzer.py File pylib/gyp/generator/analyzer.py (right): https://codereview.chromium.org/1142323006/diff/40001/pylib/gyp/generator/analyzer.py#newcode430 pylib/gyp/generator/analyzer.py:430: # executables. This is necessary as the other dependencies ...
5 years, 6 months ago (2015-06-08 18:01:17 UTC) #6
sky
5 years, 6 months ago (2015-06-08 18:25:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
fdc7b812f99e48c00e9a487bd56751bbeae07043 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698