Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1142323003: Remove duplicate application cpp files in mojo/application. (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, dcheng, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate application cpp files in mojo/application. Some of these files were forked in the initial Mandoline landing. After we forked the application code, we now had two implementations of some of these files. We only need one. Committed: https://crrev.com/0080299638e998a7cb9cdd3f5aadcf6b6ffe707b Cr-Commit-Position: refs/heads/master@{#330690}

Patch Set 1 #

Patch Set 2 : fix gypi #

Patch Set 3 : fix mojo_runner_unittests #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -1148 lines) Patch
M BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M build/gn_migration.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M components/clipboard/BUILD.gn View 2 chunks +2 lines, -8 lines 0 comments Download
M components/clipboard/clipboard_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/clipboard/main.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/html_viewer/BUILD.gn View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M components/html_viewer/ax_provider_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/html_viewer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/resource_provider/BUILD.gn View 2 chunks +2 lines, -5 lines 0 comments Download
M components/resource_provider/android/android_hooks.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/main.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/resource_provider/resource_provider_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/surfaces/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M components/surfaces/main.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/view_manager/BUILD.gn View 1 2 3 3 chunks +3 lines, -11 lines 0 comments Download
M components/view_manager/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/native_viewport/BUILD.gn View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M components/view_manager/native_viewport/main.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/native_viewport/native_viewport_application_delegate.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/native_viewport/native_viewport_impl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/cpp/tests/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/view_manager/view_manager_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/view_manager_client_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/view_manager_service_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download
M mandoline/services/core_services/android_hooks.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/services/core_services/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/ui/browser/BUILD.gn View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M mandoline/ui/browser/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/browser/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/ui/omnibox/BUILD.gn View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M mandoline/ui/omnibox/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_media_application.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/test/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
D mojo/application/BUILD.gn View 1 chunk +0 lines, -64 lines 0 comments Download
D mojo/application/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/application/app_lifetime_helper.h View 1 chunk +0 lines, -76 lines 0 comments Download
D mojo/application/app_lifetime_helper.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D mojo/application/application_runner_chromium.h View 1 chunk +0 lines, -56 lines 0 comments Download
D mojo/application/application_runner_chromium.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D mojo/application/application_test_base_chromium.h View 1 chunk +0 lines, -59 lines 0 comments Download
D mojo/application/application_test_base_chromium.cc View 1 chunk +0 lines, -147 lines 0 comments Download
D mojo/application/application_test_main_chromium.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/application/content_handler_factory.h View 1 chunk +0 lines, -80 lines 0 comments Download
D mojo/application/content_handler_factory.cc View 1 chunk +0 lines, -130 lines 0 comments Download
M mojo/application/public/cpp/BUILD.gn View 1 2 2 chunks +30 lines, -49 lines 0 comments Download
A + mojo/application/public/cpp/app_lifetime_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/application/public/cpp/application_runner.h View 2 chunks +23 lines, -11 lines 0 comments Download
M mojo/application/public/cpp/application_test_base.h View 1 chunk +0 lines, -3 lines 0 comments Download
A + mojo/application/public/cpp/content_handler_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/application/public/cpp/lib/app_lifetime_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/public/cpp/lib/application_runner.cc View 1 chunk +56 lines, -15 lines 0 comments Download
M mojo/application/public/cpp/lib/application_test_base.cc View 7 chunks +27 lines, -44 lines 0 comments Download
M mojo/application/public/cpp/lib/application_test_main.cc View 1 chunk +11 lines, -4 lines 0 comments Download
A + mojo/application/public/cpp/lib/content_handler_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/application/public/cpp/tests/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/mojo_base.gyp View 1 4 chunks +5 lines, -34 lines 0 comments Download
M mojo/mojo_shell.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/BUILD.gn View 1 2 3 3 chunks +3 lines, -16 lines 0 comments Download
M mojo/runner/android/android_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/shell_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/test/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/services/network/BUILD.gn View 3 chunks +3 lines, -9 lines 0 comments Download
M mojo/services/network/android_hooks.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/cookie_store_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/http_server_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/http_server_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/network/network_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/tcp_bound_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/tcp_connected_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/tcp_server_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/udp_socket_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/udp_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/url_loader_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/url_loader_impl_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/web_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/test_service/BUILD.gn View 2 chunks +0 lines, -8 lines 0 comments Download
M mojo/services/test_service/test_service_application.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M mojo/services/tracing/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/services/tracing/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
jam
This fixes the Linux GN clobber builder
5 years, 7 months ago (2015-05-20 01:51:48 UTC) #2
Ben Goodger (Google)
lgtm
5 years, 7 months ago (2015-05-20 01:54:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142323003/20001
5 years, 7 months ago (2015-05-20 02:13:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/54678)
5 years, 7 months ago (2015-05-20 02:20:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142323003/60001
5 years, 7 months ago (2015-05-20 02:40:33 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-20 03:37:29 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 03:38:13 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0080299638e998a7cb9cdd3f5aadcf6b6ffe707b
Cr-Commit-Position: refs/heads/master@{#330690}

Powered by Google App Engine
This is Rietveld 408576698