Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 1142313002: PDF: On Linux, convert font names to UTF-8 if needed. (Closed)

Created:
5 years, 7 months ago by Lei Zhang
Modified:
5 years, 7 months ago
Reviewers:
kochi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: On Linux, convert font names to UTF-8 if needed. BUG=419410 Committed: https://crrev.com/d295587a5a0407e0c916e8a9fca62f7b1c38748b Cr-Commit-Position: refs/heads/master@{#330801}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M chrome/renderer/pepper/pepper_flash_font_file_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 2 chunks +17 lines, -3 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
Lei Zhang
5 years, 7 months ago (2015-05-20 00:32:53 UTC) #2
kochi
Do you have any PDF that contains font name to be converted to UTF-8? I ...
5 years, 7 months ago (2015-05-20 01:57:44 UTC) #3
Lei Zhang
On 2015/05/20 01:57:44, Takayoshi Kochi wrote: > Do you have any PDF that contains font ...
5 years, 7 months ago (2015-05-20 01:59:53 UTC) #4
kochi
lgtm. Confirmed this is working with the file attached to the original issue. I also ...
5 years, 7 months ago (2015-05-20 06:24:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142313002/1
5 years, 7 months ago (2015-05-20 19:50:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 21:04:47 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 21:05:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d295587a5a0407e0c916e8a9fca62f7b1c38748b
Cr-Commit-Position: refs/heads/master@{#330801}

Powered by Google App Engine
This is Rietveld 408576698