Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1142303007: Gallery: Replace buttons in top toolbar with paper-button and new icons. (Closed)

Created:
5 years, 6 months ago by yawano
Modified:
5 years, 6 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gallery: Replace buttons in top toolbar with paper-button and new icons. BUG=488227 TEST=none Committed: https://crrev.com/d1e343107edfd573223cf3ca2c7c50938f87ddb2 Cr-Commit-Position: refs/heads/master@{#333239}

Patch Set 1 #

Patch Set 2 : Fix integration tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -161 lines) Patch
M ui/file_manager/gallery/css/gallery.css View 6 chunks +45 lines, -67 lines 0 comments Download
M ui/file_manager/gallery/gallery.html View 3 chunks +10 lines, -8 lines 0 comments Download
A ui/file_manager/gallery/images/100/delete.png View Binary file 0 comments Download
A ui/file_manager/gallery/images/100/edit.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/100/icon_1up.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/100/icon_1up_selected.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/100/icon_delete.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/100/icon_delete_selected.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/100/icon_edit.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/100/icon_edit_selected.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/100/icon_mosaic.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/100/icon_mosaic_selected.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/100/icon_print.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/100/icon_print_selected.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/100/icon_share.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/100/icon_share_selected.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/100/icon_slideshow.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/100/icon_slideshow_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/100/mosaic_view.png View Binary file 0 comments Download
A ui/file_manager/gallery/images/100/print.png View Binary file 0 comments Download
A ui/file_manager/gallery/images/100/share.png View Binary file 0 comments Download
A ui/file_manager/gallery/images/100/slide_view.png View Binary file 0 comments Download
A ui/file_manager/gallery/images/100/slideshow.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/delete.png View Binary file 0 comments Download
A ui/file_manager/gallery/images/200/edit.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/200/icon_1up.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/200/icon_1up_selected.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/200/icon_delete.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/200/icon_delete_selected.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/200/icon_edit.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/200/icon_edit_selected.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/200/icon_mosaic.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/200/icon_mosaic_selected.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/200/icon_print.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/200/icon_print_selected.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/200/icon_share.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/200/icon_share_selected.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/200/icon_slideshow.png View Binary file 0 comments Download
D ui/file_manager/gallery/images/200/icon_slideshow_selected.png View Binary file 0 comments Download
A + ui/file_manager/gallery/images/200/mosaic_view.png View Binary file 0 comments Download
A ui/file_manager/gallery/images/200/print.png View Binary file 0 comments Download
A ui/file_manager/gallery/images/200/share.png View Binary file 0 comments Download
A ui/file_manager/gallery/images/200/slide_view.png View Binary file 0 comments Download
A ui/file_manager/gallery/images/200/slideshow.png View Binary file 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 7 chunks +92 lines, -76 lines 0 comments Download
M ui/file_manager/gallery/js/slide_mode.js View 3 chunks +3 lines, -8 lines 0 comments Download
M ui/file_manager/integration_tests/gallery/photo_editor.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/integration_tests/gallery/slide_mode.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
yawano
PTAL. Thank you!
5 years, 6 months ago (2015-06-05 07:38:54 UTC) #2
mtomasz
lgtm!
5 years, 6 months ago (2015-06-05 09:50:42 UTC) #3
yawano
On 2015/06/05 09:50:42, mtomasz wrote: > lgtm! Thank you!
5 years, 6 months ago (2015-06-05 09:51:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142303007/1
5 years, 6 months ago (2015-06-05 09:51:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/64626)
5 years, 6 months ago (2015-06-05 11:02:31 UTC) #8
yawano
Fixed integration_tests. PTAL again. Thank you!
5 years, 6 months ago (2015-06-08 04:04:34 UTC) #9
mtomasz
lgtm!
5 years, 6 months ago (2015-06-08 04:15:44 UTC) #10
yawano
On 2015/06/08 04:15:44, mtomasz wrote: > lgtm! Thank you!
5 years, 6 months ago (2015-06-08 04:18:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142303007/20001
5 years, 6 months ago (2015-06-08 04:19:06 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-08 04:22:32 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 04:23:13 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d1e343107edfd573223cf3ca2c7c50938f87ddb2
Cr-Commit-Position: refs/heads/master@{#333239}

Powered by Google App Engine
This is Rietveld 408576698