Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1142303005: Remove legacy SELECT popup code. (Closed)

Created:
5 years, 6 months ago by tkent
Modified:
5 years, 6 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove legacy SELECT popup code. The code is unused since M43 release. This CL has no behavior changes. BUG=482686 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196486

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3779 lines) Patch
M Source/core/layout/LayoutThemeDefault.cpp View 1 chunk +1 line, -9 lines 0 comments Download
M Source/platform/HostWindow.h View 2 chunks +0 lines, -7 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
D Source/web/PopupContainer.h View 1 chunk +0 lines, -170 lines 0 comments Download
D Source/web/PopupContainer.cpp View 1 chunk +0 lines, -500 lines 0 comments Download
D Source/web/PopupContainerClient.h View 1 chunk +0 lines, -47 lines 0 comments Download
D Source/web/PopupContainerTest.cpp View 1 chunk +0 lines, -196 lines 0 comments Download
D Source/web/PopupListBox.h View 1 chunk +0 lines, -314 lines 0 comments Download
D Source/web/PopupListBox.cpp View 1 chunk +0 lines, -1033 lines 0 comments Download
D Source/web/PopupMenuChromium.h View 1 chunk +0 lines, -66 lines 0 comments Download
D Source/web/PopupMenuChromium.cpp View 1 chunk +0 lines, -106 lines 0 comments Download
D Source/web/PopupMenuTest.cpp View 1 chunk +0 lines, -641 lines 0 comments Download
D Source/web/WebPopupMenuImpl.h View 1 chunk +0 lines, -146 lines 0 comments Download
D Source/web/WebPopupMenuImpl.cpp View 1 chunk +0 lines, -456 lines 0 comments Download
M Source/web/WebViewImpl.h View 4 chunks +2 lines, -10 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 10 chunks +7 lines, -59 lines 0 comments Download
M Source/web/web.gypi View 3 chunks +0 lines, -11 lines 0 comments Download
M public/web/WebPopupMenu.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
tkent
Keishi, would you review this please?
5 years, 6 months ago (2015-06-04 08:48:31 UTC) #5
keishi
LGTM
5 years, 6 months ago (2015-06-04 09:05:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142303005/60001
5 years, 6 months ago (2015-06-04 09:12:36 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 09:35:26 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196486

Powered by Google App Engine
This is Rietveld 408576698