Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Issue 1142303002: Revert of bluetooth: Move testing IPC from BluetoothDispatcher to BlinkTestRunner (Closed)

Created:
5 years, 7 months ago by leviw_travelin_and_unemployed
Modified:
5 years, 7 months ago
Reviewers:
Tom Sepez, scheib, ortuno, jam
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of bluetooth: Move testing IPC from BluetoothDispatcher to BlinkTestRunner (patchset #2 id:250001 of https://codereview.chromium.org/1125133005/) Reason for revert: Broke a bunch of Layout Tests. Here's an example: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=virtual%2Fstable%2Fanimations-unprefixed%2Fanimation-events-prefixed-04.html STDERR: ==28151==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000050 (pc 0x000006a00bd0 bp 0x7fff171be890 sp 0x7fff171be880 T0) STDERR: #0 0x6a00bcf in content::BluetoothDispatcherHost::SetBluetoothAdapterForTesting(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) content/browser/bluetooth/bluetooth_dispatcher_host.cc:63:43 STDERR: #1 0x4e5d9d in OnSetBluetoothAdapter content/shell/browser/layout_test/layout_test_message_filter.cc:171:3 STDERR: #2 0x4e5d9d in DispatchToMethodImpl<content::LayoutTestMessageFilter, void (content::LayoutTestMessageFilter::*)(const std::__1::basic_string<char> &), std::__1::basic_string<char> , 0> base/tuple.h:252:0 Original issue's description: > bluetooth: Move testing IPC from BluetoothDispatcher to BlinkTestRunner > > This patch removes the testing IPC from BluetoothDispatcher and > BluetoothDispatcherHost. > > This patch also changes the way the mock BluetoothAdapter was set in > BluetoothDispatcherHost. Instead of receiving an IPC to set the adapter, > BluetoothDispatcherHost exposes a function to directly set the adapter. > This function is used by LayoutTestSupport to set the adapter. > > Mock adapter flow before: > BlinkTestRunner -> LayoutTestSupport -> BluetoothDispatcher --IPC--> > BluetoothDispatcherHost (Mock constructed here) > > After: > BlinkTestRunner --IPC--> LayoutTestMessages(Mock constructed here) -> > LayoutTestSupport -> BluetoothDispatcherHost > > This is the first of two patches to remove testing from BluetoothDispatcher > and BluetoothDispatcherHost: > > [1] This patch. > [2] http://crrev.com/1132943002 > > BUG=436284 > > Committed: https://crrev.com/3f7142d0acf5e930743cbe5d754084c464ac3c85 > Cr-Commit-Position: refs/heads/master@{#330647} TBR=jam@chromium.org,scheib@chromium.org,tsepez@chromium.org,ortuno@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=436284 Committed: https://crrev.com/5e096ae82760009e5435785ca7fb2f96b0f0f473 Cr-Commit-Position: refs/heads/master@{#330653}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -58 lines) Patch
M content/browser/bluetooth/bluetooth_dispatcher_host.h View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/bluetooth/bluetooth_dispatcher_host.cc View 2 chunks +19 lines, -17 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 3 chunks +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -6 lines 0 comments Download
M content/child/blink_platform_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/bluetooth/bluetooth_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/bluetooth/bluetooth_dispatcher.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/child/bluetooth/web_bluetooth_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/bluetooth/web_bluetooth_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/common/bluetooth/bluetooth_messages.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/test/layouttest_support.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_message_filter.cc View 4 chunks +1 line, -11 lines 0 comments Download
M content/shell/common/layout_test/layout_test_messages.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/layouttest_support.cc View 2 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
leviw_travelin_and_unemployed
Created Revert of bluetooth: Move testing IPC from BluetoothDispatcher to BlinkTestRunner
5 years, 7 months ago (2015-05-20 00:18:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142303002/1
5 years, 7 months ago (2015-05-20 00:21:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 00:26:32 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 00:27:36 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e096ae82760009e5435785ca7fb2f96b0f0f473
Cr-Commit-Position: refs/heads/master@{#330653}

Powered by Google App Engine
This is Rietveld 408576698