Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1142293003: Fix compilation on xfa branch and turn on v8 deprecation warnings (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
vogelheim
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Fix compilation on xfa branch and turn on v8 deprecation warnings R=vogelheim@chromium.org BUG= Committed: https://pdfium.googlesource.com/pdfium/+/90a4181194dd8eca153cf2a101ec27e382b27a58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/standalone.gypi View 2 chunks +5 lines, -1 line 0 comments Download
M xfa/src/fxjse/src/dynprop.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-20 08:34:09 UTC) #1
vogelheim
lgtm
5 years, 7 months ago (2015-05-20 08:48:38 UTC) #2
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-20 08:49:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
90a4181194dd8eca153cf2a101ec27e382b27a58 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698