Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: Source/platform/graphics/paint/DisplayItemList.cpp

Issue 1142283006: [SP] Always paint whole non-custom scrollbars (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/ScrollableAreaPainter.cpp ('k') | Source/platform/scroll/ScrollbarTheme.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/paint/DisplayItemList.cpp
diff --git a/Source/platform/graphics/paint/DisplayItemList.cpp b/Source/platform/graphics/paint/DisplayItemList.cpp
index 35c10c012e93810feaad47f50e98c6ed72dec2ef..aaaee68b12110bf0f9ece7ad0134b9fe6aaee386 100644
--- a/Source/platform/graphics/paint/DisplayItemList.cpp
+++ b/Source/platform/graphics/paint/DisplayItemList.cpp
@@ -242,11 +242,9 @@ void DisplayItemList::commitNewDisplayItems()
updatedList.append(m_currentDisplayItems[currentDisplayItemsIndex].release());
} else {
size_t foundIndex = findOutOfOrderCachedItem(currentDisplayItemsIndex, *newDisplayItem, matchingType, displayItemIndicesByClient);
- if (foundIndex != kNotFound) {
- isSynchronized = (foundIndex == currentDisplayItemsIndex);
- updatedList.append(m_currentDisplayItems[foundIndex].release());
- }
- // else: do nothing because previously the client generated a empty picture which is not stored in the cache.
chrishtr 2015/06/03 21:19:21 The behavior this comment refers to was removed ea
Xianzhu 2015/06/03 21:32:56 Yes. I should have changed the above when I added
+ ASSERT(foundIndex != kNotFound);
+ isSynchronized = (foundIndex == currentDisplayItemsIndex);
+ updatedList.append(m_currentDisplayItems[foundIndex].release());
}
} else {
#if ENABLE(ASSERT)
« no previous file with comments | « Source/core/paint/ScrollableAreaPainter.cpp ('k') | Source/platform/scroll/ScrollbarTheme.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698