Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 1142283006: [SP] Always paint whole non-custom scrollbars (Closed)

Created:
4 years, 11 months ago by Xianzhu
Modified:
4 years, 11 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, Rik, danakj, dshwang, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[SP] Always paint whole non-custom scrollbars We use the scrollbar as the display item client for paintings of a non-custom scrollbar. This requires us always paint the whole scrollbar or paint nothing. BUG=496239 TEST=fast/scrolling/scrollbar-repaint-two-level-scrollable.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196438

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -19 lines) Patch
A LayoutTests/fast/scrolling/scrollbar-repaint-two-level-scrollable.html View 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/fast/scrolling/scrollbar-repaint-two-level-scrollable-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/paint/ScrollableAreaPainter.cpp View 1 chunk +11 lines, -6 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItemList.cpp View 1 chunk +3 lines, -5 lines 2 comments Download
M Source/platform/scroll/ScrollbarTheme.cpp View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Xianzhu
4 years, 11 months ago (2015-06-03 19:35:18 UTC) #2
chrishtr
lgtm https://codereview.chromium.org/1142283006/diff/1/Source/platform/graphics/paint/DisplayItemList.cpp File Source/platform/graphics/paint/DisplayItemList.cpp (left): https://codereview.chromium.org/1142283006/diff/1/Source/platform/graphics/paint/DisplayItemList.cpp#oldcode249 Source/platform/graphics/paint/DisplayItemList.cpp:249: // else: do nothing because previously the client ...
4 years, 11 months ago (2015-06-03 21:19:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142283006/1
4 years, 11 months ago (2015-06-03 21:20:02 UTC) #5
Xianzhu
https://codereview.chromium.org/1142283006/diff/1/Source/platform/graphics/paint/DisplayItemList.cpp File Source/platform/graphics/paint/DisplayItemList.cpp (left): https://codereview.chromium.org/1142283006/diff/1/Source/platform/graphics/paint/DisplayItemList.cpp#oldcode249 Source/platform/graphics/paint/DisplayItemList.cpp:249: // else: do nothing because previously the client generated ...
4 years, 11 months ago (2015-06-03 21:32:57 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2015-06-03 22:46:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196438

Powered by Google App Engine
This is Rietveld 408576698