Source/core/layout/LayoutPart.cpp - Issue 1142283004: Implement a Hit Test Cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutPart.cpp

Issue 1142283004: Implement a Hit Test Cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix git cl format mangling Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutPart.cpp

diff --git a/Source/core/layout/LayoutPart.cpp b/Source/core/layout/LayoutPart.cpp

index e950fcf23dc19455547d222d71dfdc66e891ada8..d8caa9cddc14ad173e6a7e8b59a64409a3eaf595 100644

--- a/Source/core/layout/LayoutPart.cpp

+++ b/Source/core/layout/LayoutPart.cpp

@@ -169,8 +169,9 @@ bool LayoutPart::nodeAtPoint(HitTestResult& result, const HitTestLocation& locat

HitTestLocation newHitTestLocation(locationInContainer, -adjustedLocation - contentOffset);

HitTestRequest newHitTestRequest(result.hitTestRequest().type() | HitTestRequest::ChildFrameHitTest);

HitTestResult childFrameResult(newHitTestRequest, newHitTestLocation);

+ childFrameResult.setValidityRect(result.validityRect());

- bool isInsideChildFrame = childRoot->hitTest(newHitTestRequest, newHitTestLocation, childFrameResult);

+ bool isInsideChildFrame = childRoot->hitTest(childFrameResult);

if (result.hitTestRequest().listBased())

result.append(childFrameResult);