Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1356)

Unified Diff: Source/core/layout/LayoutPart.cpp

Issue 1142283004: Implement a Hit Test Cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove validity rect as per Elliott's request Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/HitTestResult.cpp ('k') | Source/core/layout/LayoutView.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutPart.cpp
diff --git a/Source/core/layout/LayoutPart.cpp b/Source/core/layout/LayoutPart.cpp
index 35597aea0146a36494d82a4f6d5ae09eed5a8d86..715a734d31c509b0abde0927918327832e3d1a07 100644
--- a/Source/core/layout/LayoutPart.cpp
+++ b/Source/core/layout/LayoutPart.cpp
@@ -170,12 +170,17 @@ bool LayoutPart::nodeAtPoint(HitTestResult& result, const HitTestLocation& locat
HitTestRequest newHitTestRequest(result.hitTestRequest().type() | HitTestRequest::ChildFrameHitTest);
HitTestResult childFrameResult(newHitTestRequest, newHitTestLocation);
- bool isInsideChildFrame = childRoot->hitTest(newHitTestRequest, newHitTestLocation, childFrameResult);
+ bool isInsideChildFrame = childRoot->hitTest(childFrameResult);
- if (result.hitTestRequest().listBased())
+ if (result.hitTestRequest().listBased()) {
result.append(childFrameResult);
- else if (isInsideChildFrame)
+ } else if (isInsideChildFrame) {
+ // Force the result not to be cacheable because the parent
+ // frame should not cache this result; as it won't be notified of
+ // changes in the child.
+ childFrameResult.setCacheable(false);
result = childFrameResult;
+ }
if (isInsideChildFrame)
return true;
« no previous file with comments | « Source/core/layout/HitTestResult.cpp ('k') | Source/core/layout/LayoutView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698