Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: Source/core/layout/HitTestCache.cpp

Issue 1142283004: Implement a Hit Test Cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove validity rect as per Elliott's request Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/HitTestCache.h ('k') | Source/core/layout/HitTestRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/HitTestCache.cpp
diff --git a/Source/core/layout/HitTestCache.cpp b/Source/core/layout/HitTestCache.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..7a37eb7147d716f7fb370782969ec6958a68d81f
--- /dev/null
+++ b/Source/core/layout/HitTestCache.cpp
@@ -0,0 +1,87 @@
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "core/layout/HitTestCache.h"
+
+#include "public/platform/Platform.h"
+
+namespace blink {
+
+bool HitTestCache::lookupCachedResult(HitTestResult& hitResult, uint64_t domTreeVersion)
+{
+ bool result = false;
+ HitHistogramMetric metric = HitHistogramMetric::MISS;
+ if (hitResult.hitTestRequest().avoidCache()) {
+ metric = HitHistogramMetric::MISS_EXPLICIT_AVOID;
+ // For now we don't support rect based hit results.
+ } else if (domTreeVersion == m_domTreeVersion && !hitResult.hitTestLocation().isRectBasedTest()) {
+ for (const auto& cachedItem : m_items) {
+ if (cachedItem.hitTestLocation().point() == hitResult.hitTestLocation().point()) {
+ if (hitResult.hitTestRequest().equalForCacheability(cachedItem.hitTestRequest())) {
+ metric = HitHistogramMetric::HIT_EXACT_MATCH;
+ result = true;
+ hitResult = cachedItem;
+ break;
+ }
+ metric = HitHistogramMetric::MISS_VALIDITY_RECT_MATCHES;
+ }
+ }
+ }
+ Platform::current()->histogramEnumeration("Event.HitTest", static_cast<int>(metric), static_cast<int>(HitHistogramMetric::MAX_HIT_METRIC));
+ return result;
+}
+
+void HitTestCache::verifyCachedResult(const HitTestResult& expected, const HitTestResult& actual)
+{
+ ValidityHistogramMetric metric;
+ if (!actual.equalForCacheability(expected)) {
+ metric = expected.hitTestLocation().isRectBasedTest() ? ValidityHistogramMetric::INCORRECT_RECT_BASED_EXACT_MATCH : ValidityHistogramMetric::INCORRECT_POINT_EXACT_MATCH;
+
+ // ASSERT that the cache hit is the same as the actual result.
+ ASSERT_NOT_REACHED();
+ } else {
+ metric = ValidityHistogramMetric::VALID_EXACT_MATCH;
+ }
+ Platform::current()->histogramEnumeration("Event.HitTestValidity", static_cast<int>(metric), static_cast<int>(ValidityHistogramMetric::MAX_VALIDITY_METRIC));
+}
+
+void HitTestCache::addCachedResult(const HitTestResult& result, uint64_t domTreeVersion)
+{
+ if (!result.isCacheable())
+ return;
+
+ // If the result was a hit test on an LayoutPart and the request allowed
+ // querying of the layout part; then the part hasn't been loaded yet.
+ if (result.isOverWidget() && result.hitTestRequest().allowsChildFrameContent())
+ return;
+
+ // For now don't support rect based or list based requests.
+ if (result.hitTestLocation().isRectBasedTest() || result.hitTestRequest().listBased())
+ return;
+ if (domTreeVersion != m_domTreeVersion)
+ clear();
+ if (m_items.size() < HIT_TEST_CACHE_SIZE)
+ m_items.resize(m_updateIndex + 1);
+
+ m_items.at(m_updateIndex).cacheValues(result);
+ m_domTreeVersion = domTreeVersion;
+
+ m_updateIndex++;
+ if (m_updateIndex >= HIT_TEST_CACHE_SIZE)
+ m_updateIndex = 0;
+}
+
+void HitTestCache::clear()
+{
+ m_updateIndex = 0;
+ m_items.clear();
+}
+
+DEFINE_TRACE(HitTestCache)
+{
+ visitor->trace(m_items);
+}
+
+} // namespace blink
« no previous file with comments | « Source/core/layout/HitTestCache.h ('k') | Source/core/layout/HitTestRequest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698