Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: Source/core/dom/TreeScope.h

Issue 1142283004: Implement a Hit Test Cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adjust comments in HitTestCache.h Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/TreeScope.h
diff --git a/Source/core/dom/TreeScope.h b/Source/core/dom/TreeScope.h
index 1bfcdf91861bd05cc0b548b98cc7eebc3ba2422e..de9866df223935dc68e1143b7af76d6b547bf5c5 100644
--- a/Source/core/dom/TreeScope.h
+++ b/Source/core/dom/TreeScope.h
@@ -29,6 +29,7 @@
#include "core/CoreExport.h"
#include "core/dom/DocumentOrderedMap.h"
+#include "core/layout/HitTestRequest.h"
#include "platform/heap/Handle.h"
#include "wtf/text/AtomicString.h"
@@ -41,7 +42,6 @@ class Element;
class HTMLLabelElement;
class HTMLMapElement;
class HitTestResult;
-class HitTestRequest;
class IdTargetObserverRegistry;
class ScopedStyleResolver;
class Node;
@@ -77,6 +77,7 @@ public:
HTMLMapElement* getImageMap(const String& url) const;
Element* elementFromPoint(int x, int y) const;
+ Element* elementFromPointNoCache(int x, int y) const;
Vector<Element*> elementsFromPoint(int x, int y) const;
// For accessibility.
@@ -176,6 +177,8 @@ private:
bool rootNodeHasTreeSharedParent() const;
+ Element* hitTestPoint(int x, int y, const HitTestRequest&) const;
+
RawPtrWillBeMember<ContainerNode> m_rootNode;
RawPtrWillBeMember<Document> m_document;
RawPtrWillBeMember<TreeScope> m_parentTreeScope;
@@ -208,7 +211,7 @@ inline bool TreeScope::containsMultipleElementsWithId(const AtomicString& id) co
DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES(TreeScope)
-HitTestResult hitTestInDocument(const Document*, int x, int y);
+HitTestResult hitTestInDocument(const Document*, int x, int y, const HitTestRequest& = HitTestRequest::ReadOnly | HitTestRequest::Active);
tdresser 2015/06/10 13:35:21 Why take a reference instead of a value here?
dtapuska 2015/06/10 14:04:48 HitTestRequest is a class; so I prefer to pass cla
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698