Source/core/layout/line/RootInlineBox.cpp - Issue 1142283004: Implement a Hit Test Cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/line/RootInlineBox.cpp

Issue 1142283004: Implement a Hit Test Cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/line/RootInlineBox.cpp

diff --git a/Source/core/layout/line/RootInlineBox.cpp b/Source/core/layout/line/RootInlineBox.cpp

index 2ee8104e5a0012c93ebd54decf07284d42cce4bd..87ed2925bd75c25b5508eb6c83cd5e4cf56ec970 100644

--- a/Source/core/layout/line/RootInlineBox.cpp

+++ b/Source/core/layout/line/RootInlineBox.cpp

@@ -159,7 +159,8 @@ bool RootInlineBox::nodeAtPoint(HitTestResult& result, const HitTestLocation& lo

{

if (hasEllipsisBox() && visibleToHitTestRequest(result.hitTestRequest())) {

if (ellipsisBox()->nodeAtPoint(result, locationInContainer, accumulatedOffset, lineTop, lineBottom)) {

- layoutObject().updateHitTestResult(result, locationInContainer.point() - toLayoutSize(accumulatedOffset));

+ // TODO(dtapuska): Calculate the right line box

+ layoutObject().updateHitTestResult(result, locationInContainer.point() - toLayoutSize(accumulatedOffset), result.validityRect());

return true;

}