Source/core/layout/line/EllipsisBox.cpp - Issue 1142283004: Implement a Hit Test Cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/line/EllipsisBox.cpp

Issue 1142283004: Implement a Hit Test Cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/line/EllipsisBox.cpp

diff --git a/Source/core/layout/line/EllipsisBox.cpp b/Source/core/layout/line/EllipsisBox.cpp

index 676c8a594f20c59d142029398d4db18c3d878db7..be89af6f5ba77e6a85dc00062020dd8e72b4d807 100644

--- a/Source/core/layout/line/EllipsisBox.cpp

+++ b/Source/core/layout/line/EllipsisBox.cpp

@@ -54,7 +54,7 @@ bool EllipsisBox::nodeAtPoint(HitTestResult& result, const HitTestLocation& loca

boxOrigin.moveBy(accumulatedOffset);

FloatRectWillBeLayoutRect boundsRect(boxOrigin, size());

if (visibleToHitTestRequest(result.hitTestRequest()) && boundsRect.intersects(FloatRectWillBeLayoutRect(HitTestLocation::rectForPoint(locationInContainer.point(), 0, 0, 0, 0)))) {

- layoutObject().updateHitTestResult(result, locationInContainer.point() - toLayoutSize(adjustedLocation));

+ layoutObject().updateHitTestResult(result, locationInContainer.point() - toLayoutSize(adjustedLocation), boundsRect);

// FIXME: the call to rawValue() below is temporary and should be removed once the transition

// to LayoutUnit-based types is complete (crbug.com/321237)

if (!result.addNodeToListBasedTestResult(layoutObject().node(), locationInContainer, boundsRect.rawValue()))

« Source/core/frame/FrameView.cpp ('K') | « Source/core/layout/LayoutView.cpp ('k') | Source/core/layout/line/InlineFlowBox.cpp » ('j') | no next file with comments »