Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: Source/core/layout/LayoutTableRow.cpp

Issue 1142283004: Implement a Hit Test Cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 // Table rows cannot ever be hit tested. Effectively they do not exist. 198 // Table rows cannot ever be hit tested. Effectively they do not exist.
199 // Just forward to our children always. 199 // Just forward to our children always.
200 for (LayoutTableCell* cell = lastCell(); cell; cell = cell->previousCell()) { 200 for (LayoutTableCell* cell = lastCell(); cell; cell = cell->previousCell()) {
201 // FIXME: We have to skip over inline flows, since they can show up insi de table rows 201 // FIXME: We have to skip over inline flows, since they can show up insi de table rows
202 // at the moment (a demoted inline <form> for example). If we ever imple ment a 202 // at the moment (a demoted inline <form> for example). If we ever imple ment a
203 // table-specific hit-test method (which we should do for performance re asons anyway), 203 // table-specific hit-test method (which we should do for performance re asons anyway),
204 // then we can remove this check. 204 // then we can remove this check.
205 if (!cell->hasSelfPaintingLayer()) { 205 if (!cell->hasSelfPaintingLayer()) {
206 LayoutPoint cellPoint = flipForWritingModeForChild(cell, accumulated Offset); 206 LayoutPoint cellPoint = flipForWritingModeForChild(cell, accumulated Offset);
207 if (cell->nodeAtPoint(result, locationInContainer, cellPoint, action )) { 207 if (cell->nodeAtPoint(result, locationInContainer, cellPoint, action )) {
208 updateHitTestResult(result, locationInContainer.point() - toLayo utSize(cellPoint)); 208 // TODO(dtapuska): Fix correct cell layout rect.
209 updateHitTestResult(result, locationInContainer.point() - toLayo utSize(cellPoint), result.validityRect());
209 return true; 210 return true;
210 } 211 }
211 } 212 }
212 } 213 }
213 214
214 return false; 215 return false;
215 } 216 }
216 217
217 void LayoutTableRow::paint(const PaintInfo& paintInfo, const LayoutPoint& paintO ffset) 218 void LayoutTableRow::paint(const PaintInfo& paintInfo, const LayoutPoint& paintO ffset)
218 { 219 {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 // The cell and the row share the section's coordinate system. However 253 // The cell and the row share the section's coordinate system. However
253 // the visual overflow should be determined in the coordinate system of 254 // the visual overflow should be determined in the coordinate system of
254 // the row, that's why we shift it below. 255 // the row, that's why we shift it below.
255 LayoutUnit cellOffsetLogicalTopDifference = cell->location().y() - location( ).y(); 256 LayoutUnit cellOffsetLogicalTopDifference = cell->location().y() - location( ).y();
256 cellVisualOverflowRect.move(0, cellOffsetLogicalTopDifference); 257 cellVisualOverflowRect.move(0, cellOffsetLogicalTopDifference);
257 258
258 addVisualOverflow(cellVisualOverflowRect); 259 addVisualOverflow(cellVisualOverflowRect);
259 } 260 }
260 261
261 } // namespace blink 262 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698