Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1142273003:
Disable GL_EXT_multisampled_render_to_texture on Chromecast (Closed)
DescriptionDisable GL_EXT_multisampled_render_to_texture on Chromecast
WebGL render to texture is broken (random visual artifacts) on Chromecast.
Disabling this extension appears to fix the problem.
BUG=489871
Committed: https://crrev.com/472992489ec2d5f25a865debe7bfc53888113b80
Cr-Commit-Position: refs/heads/master@{#330671}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Rebase, ++version, remote extra spaces" #Messages
Total messages: 19 (8 generated)
halliwell@chromium.org changed reviewers: + derekjchow@chromium.org, kbr@chromium.org
kbr@chromium.org changed reviewers: + zmo@chromium.org
Great diagnosis. LGTM. +zmo as FYI.
The CQ bit was checked by halliwell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142273003/1
LGTM Please rebase on top of https://codereview.chromium.org/1133593009/ and increase the version https://codereview.chromium.org/1142273003/diff/1/gpu/config/gpu_driver_bug_l... File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/1142273003/diff/1/gpu/config/gpu_driver_bug_l... gpu/config/gpu_driver_bug_list_json.cc:1353: "disable_multisampled_render_to_texture" nit: two extra whitespace.
The CQ bit was unchecked by halliwell@chromium.org
On 2015/05/19 23:31:32, Zhenyao Mo wrote: > LGTM > > Please rebase on top of https://codereview.chromium.org/1133593009/ and increase > the version > > https://codereview.chromium.org/1142273003/diff/1/gpu/config/gpu_driver_bug_l... > File gpu/config/gpu_driver_bug_list_json.cc (right): > > https://codereview.chromium.org/1142273003/diff/1/gpu/config/gpu_driver_bug_l... > gpu/config/gpu_driver_bug_list_json.cc:1353: > "disable_multisampled_render_to_texture" > nit: two extra whitespace. Done.
The CQ bit was checked by halliwell@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org, zmo@chromium.org Link to the patchset: https://codereview.chromium.org/1142273003/#ps20001 (title: "Rebase, ++version, remote extra spaces"")
The CQ bit was unchecked by halliwell@chromium.org
On 2015/05/19 23:38:26, halliwell wrote: > On 2015/05/19 23:31:32, Zhenyao Mo wrote: > > LGTM > > > > Please rebase on top of https://codereview.chromium.org/1133593009/ and > increase > > the version > > > > > https://codereview.chromium.org/1142273003/diff/1/gpu/config/gpu_driver_bug_l... > > File gpu/config/gpu_driver_bug_list_json.cc (right): > > > > > https://codereview.chromium.org/1142273003/diff/1/gpu/config/gpu_driver_bug_l... > > gpu/config/gpu_driver_bug_list_json.cc:1353: > > "disable_multisampled_render_to_texture" > > nit: two extra whitespace. > > Done. @zmo / kbr - do either of you know how I go about submitting this now? I unchecked the CQ box when zmo commented that rebase was needed. Now CQ seems kind of stuck ... thinks it's processing patch set 1 but nothing is actually happening as far as I can tell ...
On 2015/05/20 01:01:55, halliwell wrote: > On 2015/05/19 23:38:26, halliwell wrote: > > On 2015/05/19 23:31:32, Zhenyao Mo wrote: > > > LGTM > > > > > > Please rebase on top of https://codereview.chromium.org/1133593009/ and > > increase > > > the version > > > > > > > > > https://codereview.chromium.org/1142273003/diff/1/gpu/config/gpu_driver_bug_l... > > > File gpu/config/gpu_driver_bug_list_json.cc (right): > > > > > > > > > https://codereview.chromium.org/1142273003/diff/1/gpu/config/gpu_driver_bug_l... > > > gpu/config/gpu_driver_bug_list_json.cc:1353: > > > "disable_multisampled_render_to_texture" > > > nit: two extra whitespace. > > > > Done. > > @zmo / kbr - do either of you know how I go about submitting this now? I > unchecked the CQ box when zmo commented that rebase was needed. Now CQ seems > kind of stuck ... thinks it's processing patch set 1 but nothing is actually > happening as far as I can tell ... You should be able to just check the CQ box for patch set 2. Did that not work?
The CQ bit was checked by halliwell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142273003/20001
On 2015/05/20 01:04:00, Ken Russell wrote: > On 2015/05/20 01:01:55, halliwell wrote: > > On 2015/05/19 23:38:26, halliwell wrote: > > > On 2015/05/19 23:31:32, Zhenyao Mo wrote: > > > > LGTM > > > > > > > > Please rebase on top of https://codereview.chromium.org/1133593009/ and > > > increase > > > > the version > > > > > > > > > > > > > > https://codereview.chromium.org/1142273003/diff/1/gpu/config/gpu_driver_bug_l... > > > > File gpu/config/gpu_driver_bug_list_json.cc (right): > > > > > > > > > > > > > > https://codereview.chromium.org/1142273003/diff/1/gpu/config/gpu_driver_bug_l... > > > > gpu/config/gpu_driver_bug_list_json.cc:1353: > > > > "disable_multisampled_render_to_texture" > > > > nit: two extra whitespace. > > > > > > Done. > > > > @zmo / kbr - do either of you know how I go about submitting this now? I > > unchecked the CQ box when zmo commented that rebase was needed. Now CQ seems > > kind of stuck ... thinks it's processing patch set 1 but nothing is actually > > happening as far as I can tell ... > > You should be able to just check the CQ box for patch set 2. Did that not work? Interesting ... that worked now, although it didn't work earlier (at 4.38, it just generated a 'patch set was uploaded to cq after lgtm' email and then didn't do anything else). Maybe I had to wait for patch set 1 to stop processing or something. Thanks.
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/472992489ec2d5f25a865debe7bfc53888113b80 Cr-Commit-Position: refs/heads/master@{#330671} |
