Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1142253002: Don't show pointer cursor over an icon button if it is disabled. (Closed)

Created:
5 years, 7 months ago by dzhioev (left Google)
Modified:
5 years, 7 months ago
Reviewers:
achuith, achuithb
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't show pointer cursor over an icon button if it is disabled. BUG=487849 TEST=manually Committed: https://crrev.com/8caa763157d5d0747e0205e18a16286197baa758 Cr-Commit-Position: refs/heads/master@{#330627}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/login/gaia_icon_button.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dzhioev (left Google)
Hi, PTAL
5 years, 7 months ago (2015-05-19 20:59:26 UTC) #2
achuithb
Lgtm My comfort with css is low so please feel free to get another review ...
5 years, 7 months ago (2015-05-19 21:17:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142253002/1
5 years, 7 months ago (2015-05-19 21:32:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 22:03:17 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 22:04:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8caa763157d5d0747e0205e18a16286197baa758
Cr-Commit-Position: refs/heads/master@{#330627}

Powered by Google App Engine
This is Rietveld 408576698