Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1142203002: qcms: Silence __force_align_arg_pointer__ warning on Armv8 (Closed)

Created:
5 years, 7 months ago by ingemara
Modified:
5 years, 7 months ago
Reviewers:
Noel Gordon
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

qcms: Silence __force_align_arg_pointer__ warning on Armv8 BUG=490016 Committed: https://crrev.com/3972bf0cd73430c02e3c11db06a49a3bd56a81a3 Cr-Commit-Position: refs/heads/master@{#331349}

Patch Set 1 #

Patch Set 2 : Invert the list to only use the attribute on non-64 bit x86 #

Patch Set 3 : Update README #

Total comments: 1

Patch Set 4 : Add bug reference to README #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/qcms/README.chromium View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M third_party/qcms/src/transform.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
ingemara
5 years, 7 months ago (2015-05-19 12:59:53 UTC) #2
Noel Gordon
Could you update the README file also please, and add a bug reference.
5 years, 7 months ago (2015-05-19 22:48:04 UTC) #3
ingemara
5 years, 7 months ago (2015-05-22 08:58:54 UTC) #4
ingemara
Ping
5 years, 7 months ago (2015-05-26 07:30:06 UTC) #5
Noel Gordon
I see you added a bug (and duped mine): good.
5 years, 7 months ago (2015-05-26 07:46:06 UTC) #6
Noel Gordon
https://codereview.chromium.org/1142203002/diff/40001/third_party/qcms/README.chromium File third_party/qcms/README.chromium (right): https://codereview.chromium.org/1142203002/diff/40001/third_party/qcms/README.chromium#newcode30 third_party/qcms/README.chromium:30: - Limit the use an x86-only attribute to 32-bit ...
5 years, 7 months ago (2015-05-26 07:49:33 UTC) #7
Noel Gordon
LGTM assuming the change above is done.
5 years, 7 months ago (2015-05-26 07:50:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142203002/60001
5 years, 7 months ago (2015-05-26 07:55:22 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-26 11:56:58 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 11:57:55 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3972bf0cd73430c02e3c11db06a49a3bd56a81a3
Cr-Commit-Position: refs/heads/master@{#331349}

Powered by Google App Engine
This is Rietveld 408576698