Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 1142193002: Revert of ServiceWorker: Use SimpleCache for the script cache (Closed)

Created:
5 years, 7 months ago by nhiroki
Modified:
5 years, 7 months ago
Reviewers:
kinuko, michaeln
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, darin-cc_chromium.org, jkarlin+watch_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, gavinp, falken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ServiceWorker: Use SimpleCache for the script cache (patchset #7 id:230001 of https://codereview.chromium.org/1140853002/) Reason for revert: We'll reland this CL with DiskCache migration code. Original issue's description: > ServiceWorker: Use SimpleCache for the script cache > > This CL migrates the backend of ServiceWorkerDiskCache from Default to > SimpleCache on all platforms. > > If old DiskCache images exist, > (1) DiskCache backend fails to open an pre-existing data due to incompatible > format (in both Default->SimpleCache and SimpleCache->Default cases), > (2) ServiceWorkerStorage wipes out all cached scripts and registrations via > DeleteAndStartOver, and > (3) navigation falls back to network. > > BUG=487482 > TEST=manual (use DiskCache and SimpleCache alternately and make sure the system can recover) > > Committed: https://crrev.com/a00e5be5a06e626de1b62cbfc7c350bef08647ea > Cr-Commit-Position: refs/heads/master@{#330274} TBR=michaeln@chromium.org BUG=487482 Committed: https://crrev.com/d89b8b3d592ee47b47d5774712bbec541188d114 Cr-Commit-Position: refs/heads/master@{#330505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -24 lines) Patch
M content/browser/appcache/appcache_disk_cache.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/appcache/appcache_disk_cache.cc View 3 chunks +8 lines, -14 lines 0 comments Download
M content/browser/service_worker/service_worker_disk_cache.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_disk_cache.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
nhiroki
Created Revert of ServiceWorker: Use SimpleCache for the script cache
5 years, 7 months ago (2015-05-19 09:47:14 UTC) #1
nhiroki
kinuko@, can I land this?
5 years, 7 months ago (2015-05-19 09:49:34 UTC) #2
kinuko
lgtm
5 years, 7 months ago (2015-05-19 10:24:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142193002/1
5 years, 7 months ago (2015-05-19 10:50:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 11:38:36 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 11:39:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d89b8b3d592ee47b47d5774712bbec541188d114
Cr-Commit-Position: refs/heads/master@{#330505}

Powered by Google App Engine
This is Rietveld 408576698