Issue 1142183002: Add a newline to the font load debug message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1142183002: Add a newline to the font load debug message (Closed)

Created:
5 years, 7 months ago by Kimmo Kinnunen

Modified:
5 years, 7 months ago

Reviewers:
bungeman-skia

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@nvpr-cache-special-paths

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Add a newline to the font load debug message Add a newline to the font load debug message. Helps reading nanobench results. Otherwise the message "Resource /fonts/Funkster.ttf not a valid font." causes first result be hard to read or missing. Committed: https://skia.googlesource.com/skia/+/503bd77b8987ff611f870698fd846d1a24825bea

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/Resources.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142183002/1

5 years, 7 months ago (2015-05-19 20:44:52 UTC) #6

commit-bot: I haz the power

5 years, 7 months ago (2015-05-19 20:50:58 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/503bd77b8987ff611f870698fd846d1a24825bea

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages