components/infobars/core/confirm_infobar_delegate.cc - Issue 1142153002: Simplify infobar expiry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/infobars/core/confirm_infobar_delegate.cc

Issue 1142153002: Simplify infobar expiry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android compile Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/infobars/core/confirm_infobar_delegate.cc

diff --git a/components/infobars/core/confirm_infobar_delegate.cc b/components/infobars/core/confirm_infobar_delegate.cc

index 9c00449a5a22bc0bf1e3ca7245c41ca96e074ca4..daef8c1536e378967b41a85577d363425da1f0ad 100644

--- a/components/infobars/core/confirm_infobar_delegate.cc

+++ b/components/infobars/core/confirm_infobar_delegate.cc

@@ -53,12 +53,6 @@ ConfirmInfoBarDelegate::ConfirmInfoBarDelegate()

: InfoBarDelegate() {

}

-bool ConfirmInfoBarDelegate::ShouldExpireInternal(

- const NavigationDetails& details) const {

- return !details.did_replace_entry &&

- InfoBarDelegate::ShouldExpireInternal(details);

bool ConfirmInfoBarDelegate::EqualsDelegate(InfoBarDelegate* delegate) const {

ConfirmInfoBarDelegate* confirm_delegate =

delegate->AsConfirmInfoBarDelegate();