chrome/browser/password_manager/save_password_infobar_delegate.cc - Issue 1142153002: Simplify infobar expiry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/save_password_infobar_delegate.cc

Issue 1142153002: Simplify infobar expiry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android compile Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/password_manager/save_password_infobar_delegate.cc

diff --git a/chrome/browser/password_manager/save_password_infobar_delegate.cc b/chrome/browser/password_manager/save_password_infobar_delegate.cc

index 7e2f2d84c221a4b712f79f650ee5381a70f041f9..ea3b83fad9cd4ac260a88c1e679082c3904ba749 100644

--- a/chrome/browser/password_manager/save_password_infobar_delegate.cc

+++ b/chrome/browser/password_manager/save_password_infobar_delegate.cc

@@ -133,8 +133,7 @@ int SavePasswordInfoBarDelegate::GetIconID() const {

bool SavePasswordInfoBarDelegate::ShouldExpire(

const NavigationDetails& details) const {

- return !details.is_redirect &&

- infobars::InfoBarDelegate::ShouldExpire(details);

+ return !details.is_redirect && ConfirmInfoBarDelegate::ShouldExpire(details);

}

void SavePasswordInfoBarDelegate::InfoBarDismissed() {