Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3287)

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api.cc

Issue 1142153002: Simplify infobar expiry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android compile Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/debugger/debugger_api.cc
diff --git a/chrome/browser/extensions/api/debugger/debugger_api.cc b/chrome/browser/extensions/api/debugger/debugger_api.cc
index 14638efb2966e593f6271a90237775ebb14386e3..50ec82b59212e05ab759df5ccd791478d05e5e5e 100644
--- a/chrome/browser/extensions/api/debugger/debugger_api.cc
+++ b/chrome/browser/extensions/api/debugger/debugger_api.cc
@@ -170,8 +170,8 @@ class ExtensionDevToolsInfoBarDelegate : public ConfirmInfoBarDelegate {
// ConfirmInfoBarDelegate:
Type GetInfoBarType() const override;
+ bool ShouldExpire(const NavigationDetails& details) const override;
void InfoBarDismissed() override;
- bool ShouldExpireInternal(const NavigationDetails& details) const override;
base::string16 GetMessageText() const override;
int GetButtons() const override;
bool Cancel() override;
@@ -214,16 +214,16 @@ ExtensionDevToolsInfoBarDelegate::GetInfoBarType() const {
return WARNING_TYPE;
}
+bool ExtensionDevToolsInfoBarDelegate::ShouldExpire(
+ const NavigationDetails& details) const {
+ return false;
+}
+
void ExtensionDevToolsInfoBarDelegate::InfoBarDismissed() {
if (client_host_)
client_host_->MarkAsDismissed();
}
-bool ExtensionDevToolsInfoBarDelegate::ShouldExpireInternal(
- const NavigationDetails& details) const {
- return false;
-}
-
base::string16 ExtensionDevToolsInfoBarDelegate::GetMessageText() const {
return l10n_util::GetStringFUTF16(IDS_DEV_TOOLS_INFOBAR_LABEL,
base::UTF8ToUTF16(client_name_));

Powered by Google App Engine
This is Rietveld 408576698