Issue 1142123004: [Effen] Rationalise RenderNodeWrapper and OneChildListRenderNodeWrapper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1142123004: [Effen] Rationalise RenderNodeWrapper and OneChildListRenderNodeWrapper. (Closed)

Created:
5 years, 7 months ago by Hixie

Modified:
5 years, 7 months ago

Reviewers:
eseidel, abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

[Effen] Rationalise RenderNodeWrapper and OneChildListRenderNodeWrapper. The style syncing logic that was in OneChildListRenderNodeWrapper is now in RenderNodeWrapper. TextFragment and Image now just inherit directly from RenderNodeWrapper. OneChildListRenderNodeWrapper now only deals with syncing children. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/43a5537bc5568e5e3620b3e6fe0e6b89b16f3db9

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -53 lines)			Patch
	M	sky/framework/fn.dart	View		9 chunks	+58 lines, -53 lines	0 comments	Download

Total messages: 5 (2 generated)

Hixie

5 years, 7 months ago (2015-05-18 21:41:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
43a5537bc5568e5e3620b3e6fe0e6b89b16f3db9 (presubmit successful).