content/renderer/accessibility/renderer_accessibility_browsertest.cc - Issue 1142123002: Remove swapped-out usage in --site-per-process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/renderer_accessibility_browsertest.cc

Issue 1142123002: Remove swapped-out usage in --site-per-process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Readd back overriden version of CreateRenderView in TestRenderViewHost. Fixes CleanUpSwappedOutRVHO… Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_view_host_impl.cc ('K') | « content/public/test/test_renderer_host.h ('k') | content/renderer/history_entry.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/renderer_accessibility_browsertest.cc

diff --git a/content/renderer/accessibility/renderer_accessibility_browsertest.cc b/content/renderer/accessibility/renderer_accessibility_browsertest.cc

index b237d238f03693106a91ce80deb20958164412ab..b1d4c0b0758429c7c4e8c9a27378dc6926e9f3b4 100644

--- a/content/renderer/accessibility/renderer_accessibility_browsertest.cc

+++ b/content/renderer/accessibility/renderer_accessibility_browsertest.cc

@@ -6,6 +6,7 @@

#include "base/time/time.h"

#include "content/common/frame_messages.h"

#include "content/common/view_message_enums.h"

+#include "content/public/common/content_switches.h"

#include "content/public/test/render_view_test.h"

#include "content/renderer/accessibility/renderer_accessibility.h"

#include "content/renderer/render_frame_impl.h"

@@ -156,6 +157,14 @@ TEST_F(RendererAccessibilityTest, SendFullAccessibilityTreeOnReload) {

TEST_F(RendererAccessibilityTest,

MAYBE_AccessibilityMessagesQueueWhileSwappedOut) {

+ // This test breaks down in --site-per-process, as swapping out destroys

+ // the main frame and it cannot be further navigated.

+ // TODO(nasko): Figure out what this behavior looks like when swapped out

+ // no longer exists.

+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(

+ switches::kSitePerProcess)) {

+ return;

+ }

std::string html =

"<body>"

" <p>Hello, world.</p>"