content/browser/frame_host/render_frame_host_manager_browsertest.cc - Issue 1142123002: Remove swapped-out usage in --site-per-process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager_browsertest.cc

Issue 1142123002: Remove swapped-out usage in --site-per-process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Readd back overriden version of CreateRenderView in TestRenderViewHost. Fixes CleanUpSwappedOutRVHO… Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_manager.cc ('K') | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('j') | content/browser/renderer_host/render_view_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager_browsertest.cc

diff --git a/content/browser/frame_host/render_frame_host_manager_browsertest.cc b/content/browser/frame_host/render_frame_host_manager_browsertest.cc

index aec9dac07487b881587c7c7623cf0a40b5503dfd..95673945ee10a2248e92c6e37296446373315ee0 100644

--- a/content/browser/frame_host/render_frame_host_manager_browsertest.cc

+++ b/content/browser/frame_host/render_frame_host_manager_browsertest.cc

@@ -1160,6 +1160,12 @@ IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest, MAYBE_BackForwardNotStale) {

// Swapping out a render view should update its visiblity state.

IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest,

SwappedOutViewHasCorrectVisibilityState) {

+ // This test is invalid in --site-per-process mode, as swapped-out is no

+ // longer used.

+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(

+ switches::kSitePerProcess)) {

+ return;

+ }

StartServer();

// Load a page with links that open in a new window.