Issue 11421223: Add the magnifier shortcut keys (Ctrl+F6/F7) for debugging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11421223: Add the magnifier shortcut keys (Ctrl+F6/F7) for debugging. (Closed)

Created:
8 years ago by yoshiki

Modified:
8 years ago

Reviewers:
Daniel Erat, sky

CC:
chromium-reviews, mazda+watch_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add the magnifier shortcut keys (Ctrl+F6/F7) for debugging. Original shortcut keys (Ctrl+Alt+F6/F7) are often the keys to switch VTs and cannot be used as the magnifier shortcuts on almost all Linux workstations. This CL adds additional shortcut keys only for debug mode. BUG=none TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171121

Patch Set 1 #

Total comments: 2

Patch Set 2 : review fix (#3) #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	ash/accelerators/accelerator_table.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/11421223/diff/1/ash/accelerators/accelerator_table.cc File ash/accelerators/accelerator_table.cc (right): https://codereview.chromium.org/11421223/diff/1/ash/accelerators/accelerator_table.cc#newcode61 ash/accelerators/accelerator_table.cc:61: #if !defined(NDEBUG) Can you move this with the ...

8 years ago (2012-12-04 22:25:03 UTC) #3

yoshiki

8 years ago (2012-12-05 02:00:06 UTC) #4

Thanks!

https://codereview.chromium.org/11421223/diff/1/ash/accelerators/accelerator_...
File ash/accelerators/accelerator_table.cc (right):

https://codereview.chromium.org/11421223/diff/1/ash/accelerators/accelerator_...
ash/accelerators/accelerator_table.cc:61: #if !defined(NDEBUG)
On 2012/12/04 22:25:04, sky wrote:
> Can you move this with the other !NDEBUG section @ 71?

Done.

Expand Messages | Collapse Messages