Issue 11421199: Update webview license tool to match licenses.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11421199: Update webview license tool to match licenses.py. (Closed)

Created:
8 years ago by Torne

Modified:
8 years ago

Reviewers:
mnaganov (inactive)

CC:
chromium-reviews, pam+watch_chromium.org, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update webview license tool to match licenses.py. The FindThirdPartyDirs function no longer filters out empty/missing directories as of r170273; update webview_licenses to do this. Also, actually print the name of the directory causing a license error to make debugging failures easier. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170736

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	android_webview/tools/webview_licenses.py	View		2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages