Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11421197: Implement SyncFileSystemService::GetFileSyncStatus method (Closed)

Created:
8 years ago by kinuko
Modified:
8 years ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org, calvinlo
Visibility:
Public.

Description

Implement SyncFileSystemService::GetFileSyncStatus method - The method takes FileSystemURL and returns a new enum: fileapi::SyncFileStatus, which takes one of either: UNKNOWN, SYNCED, HAS_PENDING_CHANGES or CONFLICTING BUG=163860 TEST=SyncFileSystemService.GetFileSyncStatus Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170886

Patch Set 1 #

Total comments: 8

Patch Set 2 : indent fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -3 lines) Patch
M chrome/browser/sync_file_system/drive_file_sync_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/local_file_sync_service.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/local_file_sync_service.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/mock_remote_file_sync_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/mock_remote_file_sync_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/remote_file_sync_service.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 2 chunks +39 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service_unittest.cc View 1 3 chunks +97 lines, -3 lines 0 comments Download
M webkit/fileapi/syncable/local_file_sync_context.h View 2 chunks +10 lines, -0 lines 0 comments Download
M webkit/fileapi/syncable/local_file_sync_context.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M webkit/fileapi/syncable/sync_callbacks.h View 2 chunks +5 lines, -0 lines 0 comments Download
A webkit/fileapi/syncable/sync_file_status.h View 1 chunk +29 lines, -0 lines 0 comments Download
M webkit/fileapi/webkit_fileapi.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kinuko
PTL
8 years ago (2012-12-03 08:08:53 UTC) #1
nhiroki
LGTM! https://codereview.chromium.org/11421197/diff/1/chrome/browser/sync_file_system/sync_file_system_service_unittest.cc File chrome/browser/sync_file_system/sync_file_system_service_unittest.cc (right): https://codereview.chromium.org/11421197/diff/1/chrome/browser/sync_file_system/sync_file_system_service_unittest.cc#newcode561 chrome/browser/sync_file_system/sync_file_system_service_unittest.cc:561: .WillOnce(Return(false)); nit: 6 -> 4 indents? https://codereview.chromium.org/11421197/diff/1/chrome/browser/sync_file_system/sync_file_system_service_unittest.cc#newcode579 chrome/browser/sync_file_system/sync_file_system_service_unittest.cc:579: ...
8 years ago (2012-12-03 08:47:23 UTC) #2
kinuko
Thanks, fixed the indentation. https://codereview.chromium.org/11421197/diff/1/chrome/browser/sync_file_system/sync_file_system_service_unittest.cc File chrome/browser/sync_file_system/sync_file_system_service_unittest.cc (right): https://codereview.chromium.org/11421197/diff/1/chrome/browser/sync_file_system/sync_file_system_service_unittest.cc#newcode561 chrome/browser/sync_file_system/sync_file_system_service_unittest.cc:561: .WillOnce(Return(false)); On 2012/12/03 08:47:24, nhiroki ...
8 years ago (2012-12-03 09:08:42 UTC) #3
kinuko
(Will be submitting unless no one object)
8 years ago (2012-12-04 02:55:01 UTC) #4
kinuko
On 2012/12/04 02:55:01, kinuko wrote: > (Will be submitting unless no one object) unless someone ...
8 years ago (2012-12-04 02:55:18 UTC) #5
nhiroki
On 2012/12/04 02:55:18, kinuko wrote: > On 2012/12/04 02:55:01, kinuko wrote: > > (Will be ...
8 years ago (2012-12-04 03:23:41 UTC) #6
tzik
8 years ago (2012-12-04 04:04:10 UTC) #7 
lgtm

Powered by Google App Engine
This is Rietveld 408576698