chrome/browser/ui/webui/extensions/extension_activity_ui.cc - Issue 11421192: Save extension activity log to a file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/extensions/extension_activity_ui.cc

Issue 11421192: Save extension activity log to a file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: tryserver bugfix Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log_unittest.cc ('K') | « chrome/browser/ui/webui/extensions/extension_activity_ui.h ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/extensions/extension_activity_ui.cc

===================================================================

--- chrome/browser/ui/webui/extensions/extension_activity_ui.cc (revision 173751)

+++ chrome/browser/ui/webui/extensions/extension_activity_ui.cc (working copy)

@@ -42,9 +42,10 @@

source->add_resource_path("extension_activity.js", IDR_EXTENSION_ACTIVITY_JS);

source->set_default_resource(IDR_EXTENSION_ACTIVITY_HTML);

- Profile* profile = Profile::FromWebUI(web_ui);

- ChromeURLDataManager::AddDataSource(profile, source);

- ChromeURLDataManager::AddDataSource(profile, new SharedResourcesDataSource());

+ profile_ = Profile::FromWebUI(web_ui);

+ ChromeURLDataManager::AddDataSource(profile_, source);

+ ChromeURLDataManager::AddDataSource(

+ profile_, new SharedResourcesDataSource());

// Callback handlers.

web_ui->RegisterMessageCallback("requestExtensionData",

@@ -54,7 +55,8 @@

ExtensionActivityUI::~ExtensionActivityUI() {

if (extension_)

- extensions::ActivityLog::GetInstance()->RemoveObserver(extension_, this);

+ extensions::ActivityLog::GetInstance(profile_)->RemoveObserver(

+ extension_, this);

}

void ExtensionActivityUI::HandleRequestExtensionData(

@@ -65,8 +67,7 @@

if (!args->GetString(0, &extension_id))

return;

- ExtensionService* extension_service = Profile::FromWebUI(web_ui())->

- GetExtensionService();

+ ExtensionService* extension_service = profile_->GetExtensionService();

extension_ = extension_service->GetExtensionById(extension_id, false);

if (!extension_)

return;

@@ -90,7 +91,7 @@

web_ui()->CallJavascriptFunction("extension_activity.handleExtensionData",

result);

- extensions::ActivityLog::GetInstance()->AddObserver(extension_, this);

+ extensions::ActivityLog::GetInstance(profile_)->AddObserver(extension_, this);

}

void ExtensionActivityUI::OnExtensionActivity(